fix(cluster): fix pbi autoscaling #2592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Simplifies Pegboard runtime detection in the cluster topology system by removing special-case handling for isolate types and consolidating runtime type detection logic.
- Removed
PegboardIsolatepool type filtering inpackages/core/services/cluster/src/ops/datacenter/topology_get/mod.rs - Simplified
Runtimeenum conversion to treat all Pegboard client IDs uniformly - Removed special handling for Pegboard isolate types, streamlining server runtime detection
- Unified Pegboard runtime logic to handle all Pegboard servers consistently regardless of pool type
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
3ea0668
|
| Status: | 🚫 Build failed. |
MasterPtato
force-pushed
the
06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts
branch
from
3a69467 to
e2238dc
Compare
MasterPtato
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
5fff3fc to
799de6e
Compare
Deploying rivet-hub with
|
| Latest commit: |
3ea0668
|
| Status: | 🚫 Build failed. |
Deploying rivet-studio with
|
| Latest commit: |
3ea0668
|
| Status: | 🚫 Build failed. |
NathanFlurry
force-pushed
the
06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts
branch
from
e2238dc to
ff90f58
Compare
NathanFlurry
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
799de6e to
0129a3b
Compare
This was referenced Jun 15, 2025
abcxff
force-pushed
the
06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts
branch
from
66c9ae7 to
4ee85d0
Compare
MasterPtato
force-pushed
the
06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts
branch
from
4ee85d0 to
66c9ae7
Compare
MasterPtato
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
58853a8 to
3ea0668
Compare
This was referenced Jun 19, 2025
NathanFlurry
force-pushed
the
06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts
branch
from
66c9ae7 to
ff90f58
Compare
NathanFlurry
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
3ea0668 to
0129a3b
Compare
This was referenced Jun 20, 2025
MasterPtato
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
0129a3b to
db249f9
Compare
NathanFlurry
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
db249f9 to
c3bb942
Compare
NathanFlurry
force-pushed
the
06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts
branch
from
a5dffdd to
a94aa4a
Compare
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Jun 20, 2025
Closed
This was referenced Jun 28, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes