Skip to content

Commit 17620f8

Browse files
committed
fix: make artifact size changes not break wf (#2726)
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
1 parent e63f5c1 commit 17620f8

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

packages/core/services/cluster/src/workflows/server/install/install_scripts/components/vector.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ pub fn configure(namespace: &str, config: &Config, pool_type: PoolType) -> Globa
7474
// Buffer to disk for durability & reduce memory usage
7575
"buffer": {
7676
"type": "disk",
77-
"max_size": 2 * 1024 * 1024 * 1024, // 2 GiB
77+
"max_size": 2u64 * 1024 * 1024 * 1024, // 2 GiB
7878
"when_full": "block"
7979
}
8080
}

packages/edge/infra/client/manager/src/image_download_handler.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,7 @@ impl ImageDownloadHandler {
4343
// The image download started at some point in the current runtime
4444
Entry::Occupied(entry) => entry.get().clone(),
4545
// The image is not currently being downloaded
46-
Entry::Vacant(entry) => {
47-
let entry = entry.insert_entry(Arc::new(Mutex::new(false)));
48-
49-
entry.get().clone()
50-
}
46+
Entry::Vacant(entry) => entry.insert(Arc::new(Mutex::new(false))).clone(),
5147
};
5248

5349
drop(downloads_guard);

packages/edge/services/pegboard/src/workflows/actor/setup.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,10 +705,11 @@ struct ResolveArtifactsInput {
705705
dc_build_delivery_method: BuildDeliveryMethod,
706706
}
707707

708-
#[derive(Debug, Serialize, Deserialize, Hash)]
708+
#[derive(Debug, Serialize, Deserialize)]
709709
struct ResolveArtifactsOutput {
710710
artifact_url_stub: String,
711711
fallback_artifact_url: Option<String>,
712+
#[serde(default)]
712713
artifact_size_bytes: u64,
713714
}
714715

0 commit comments

Comments
 (0)