fix(pegboard): fix netns path bug #2431
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Deploying rivet with
|
| Latest commit: |
97d2838
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7c9c2127.rivet.pages.dev |
| Branch Preview URL: | https://05-07-fix-pegboard-fix-netns.rivet.pages.dev |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves network namespace management and tracing instrumentation across the Rivet codebase.
- Fixed network namespace path bug in
setup.rsby properly using both actor ID and generation number for namespace naming - Enhanced tracing in
proxy_service.rsto include route resolution parameters for better debugging - Added explicit parent span control and TLS handshake instrumentation in
server.rsfor improved connection tracking - Added backoff sleep tracing in workflow context to better monitor execution delays
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| { | ||
| Result::Ok(cmd_out) => { | ||
| if !cmd_out.status.success() { | ||
| let netns_path = self.netns_path(); |
There was a problem hiding this comment.
style: Redundant netns_path call - this path was already obtained on line 684
MasterPtato
force-pushed
the
05-07-fix_pegboard_fix_netns_path_bug
branch
from
8939903 to
97d2838
Compare
Deploying rivet-studio with
|
| Latest commit: |
97d2838
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c8845c39.rivet-studio.pages.dev |
| Branch Preview URL: | https://05-07-fix-pegboard-fix-netns.rivet-studio.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
97d2838
|
| Status: | 🚫 Build failed. |
NathanFlurry
approved these changes
May 9, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 10, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes