feat(pb): get multi-actors working e2e, add resources for builds #2465

MasterPtato · 2025-05-21T01:38:18Z

Changes

MasterPtato · 2025-05-21T01:38:36Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-05-21T01:39:52Z

Deploying rivet with Cloudflare Pages

Latest commit:	`0a4329c`
Status:	🚫 Build failed.

View logs

greptile-apps

PR Summary

This PR implements multi-actor support and resource management for builds, with significant changes across the codebase to support allocation types and optional resource specifications.

Added new BuildsAllocation types in SDKs to support both single and multi-slot allocations, with proper serialization and validation
Made actor resources optional by changing resources field from required to optional in ActorsActor type, affecting database schema and API endpoints
Renamed build-related types for better consistency (e.g., BuildsBuildKind -> BuildsKind, BuildsBuildCompression -> BuildsCompression)
Fixed critical bug in managerClient.ts where signal_actor handler incorrectly references packet.start_actor instead of packet.signal_actor
Added proper resource validation in pegboard service based on build allocation type (None, Single, Multi) with CPU millicores and memory MiB specifications

_{139 file(s) reviewed, 44 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-05-21T01:39:48Z

examples/system-test-actor/src/httpServer.ts

@@ -41,8 +37,7 @@ export function createAndStartServer(
 		const query = c.req.query("code");
 		const exitCode = query ? Number(query) : 0;

-		if (typeof Deno != "undefined") Deno.exit(exitCode);
-		else process.exit(exitCode);
+		process.exit(exitCode);

 		return c.text("unreachable");


style: unreachable code after process.exit() should be removed

greptile-apps · 2025-05-21T01:39:54Z

examples/system-test-actor/src/main.ts

+import { createAndStartUdpServer } from "./udpServer.js";
+import { connectToManager } from "./managerClient.js";
+
+let injectWebSocket: any;


style: avoid using 'any' type - should define proper type from @hono/node-ws

greptile-apps · 2025-05-21T01:39:54Z

examples/system-test-actor/src/main.ts

+const server = serve({ fetch: app.fetch, port });
+injectWebSocket(server);


style: server instance should be handled for graceful shutdown (e.g., process.on('SIGTERM'))

greptile-apps · 2025-05-21T01:39:55Z

examples/system-test-actor/src/main.ts

+
+createAndStartUdpServer();
+
+if (process.env.MULTI) {


style: use explicit boolean check for environment variable

Suggested change

if (process.env.MULTI) {

if (process.env.MULTI === 'true') {

greptile-apps · 2025-05-21T01:40:27Z

examples/system-test-actor/src/udpServer.ts

+		});
+
+
+		const port2 = Number.parseInt(portEnv);


style: port validation should happen before socket creation to avoid creating resources that may need cleanup

greptile-apps · 2025-05-21T01:59:20Z

sdks/api/runtime/rust/src/models/builds_build.rs

    #[serde(rename = "content_length")]
    pub content_length: i64,


logic: content_length is typed as i64 but documented as 'Unsigned 64 bit integer' - this could allow negative values when it shouldn't

Suggested change

#[serde(rename = "content_length")]

pub content_length: i64,

#[serde(rename = "content_length")]

pub content_length: u64,

greptile-apps · 2025-05-21T02:00:03Z

sdks/api/runtime/rust/src/models/builds_resources.rs

+
+
+
+#[derive(Clone, Debug, PartialEq, Default, Serialize, Deserialize)]


style: Missing explicit serde crate import. While it may work due to prelude, explicit imports improve code clarity

greptile-apps · 2025-05-21T02:00:45Z

sdks/api/runtime/typescript/src/api/resources/builds/resources/common/types/Allocation.ts

+export interface Allocation {
+    single?: Rivet.builds.AllocationSingle;
+    multi?: Rivet.builds.AllocationMulti;
+}


logic: Both fields being optional (marked with ?) means an Allocation could potentially have neither single nor multi set. Consider if this is the intended behavior or if at least one should be required.

greptile-apps · 2025-05-21T02:03:30Z

sdks/api/runtime/typescript/src/serialization/resources/builds/resources/common/types/Kind.ts

+);
+
+export declare namespace Kind {
+    export type Raw = "docker_image" | "oci_bundle" | "javascript";


style: Raw type should be marked as readonly to prevent accidental modification of valid enum values

greptile-apps · 2025-05-21T02:04:01Z

sdks/api/runtime/typescript/src/serialization/resources/builds/types/BuildCompression.ts

logic: Removing this file will break build compression type serialization unless this functionality has been moved elsewhere. Need to verify that equivalent functionality exists in another location before proceeding with deletion.

cloudflare-workers-and-pages · 2025-05-27T02:02:10Z

Deploying rivet-studio with Cloudflare Pages

Latest commit:	`0a4329c`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2025-05-27T02:11:19Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`0a4329c`
Status:	🚫 Build failed.

View logs

coderabbitai · 2025-07-04T01:27:16Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

claude · 2025-07-04T01:27:44Z

Claude finished @MasterPtato's task —— View job

PR Review: Multi-Actor Support and Resource Management

Review Checklist:

Read repository guidelines and understand changes
Review API design and type safety
Examine core service logic and resource management
Check database migrations and schema changes
Analyze security implications
Review example implementations
Provide comprehensive feedback

Progress: Analysis complete, providing detailed feedback...

🐛 Critical Issues

1. Logic Bug in Manager Client (High Priority)

File: examples/system-test-actor/src/managerClient.ts:59-60

// BUG: Using packet.start_actor instead of packet.signal_actor
actor_id: packet.start_actor.actor_id,
generation: packet.start_actor.generation,

Fix:

actor_id: packet.signal_actor.actor_id,
generation: packet.signal_actor.generation,

This will cause runtime errors when signal_actor packets are received.

2. Invalid API State: Empty Allocation

File: sdks/api/fern/definition/builds/common.yml:37-40

The Allocation type allows both single and multi to be null/undefined, creating invalid states. The API should enforce that exactly one allocation type is specified.

🔧 Type Safety & Design Issues

3. Type Safety Loss with serde_json::Value

Files: Multiple SDK files use serde_json::Value for single allocation

// Current (loses type safety)
pub single: Option<serde_json::Value>,

// Better approach
pub single: Option<BuildsAllocationSingle>,

4. Signed vs Unsigned Integer Mismatch

File: sdks/api/full/rust/src/models/builds_build.rs:22

// Should be u64 as documented
pub content_length: i64, // Currently signed, should be unsigned

5. Missing Validation for Slot Count

File: sdks/api/full/rust/src/models/builds_allocation_multi.rs:17

Slot count should be positive and have reasonable limits:

pub slots: u32, // Use unsigned, add validation for min/max

⚡ Performance & Resource Management

6. Good: Proper Resource Validation

The validation logic in packages/edge/services/pegboard/src/workflows/actor2/setup.rs:94-121 correctly handles different allocation types:

Single: Requires actor-specified resources
Multi: Uses build-defined resources
None: Properly rejects old builds

7. Good: Tier-Based Resource Selection

The resource selection logic properly finds appropriate tiers and validates against available resources.

🔒 Security Assessment

8. Good: Input Validation**

Resource limits are properly validated:

CPU millicores and memory MiB checks
Tag count and size limits (max 8 tags, 32 bytes labels, 1024 bytes values)
Environment variable limits (max 64, proper size limits)

9. Good: Database Security

Database fields are properly parameterized, preventing SQL injection.

📊 Database & Migration Issues

10. Missing Constraints

File: packages/edge/services/pegboard/src/workflows/actor2/migrations.rs:27

Add CHECK constraints for positive resource values:

resources_cpu_millicores INT CHECK (resources_cpu_millicores IS NULL OR resources_cpu_millicores >= 0),
resources_memory_mib INT CHECK (resources_memory_mib IS NULL OR resources_memory_mib >= 0)

🚨 API Consistency Issues

11. Allocation Logic Validation

File: packages/core/api/actor/src/route/builds.rs:396-415

The validation correctly prevents invalid states:

match (&alloc.single, &alloc.multi) {
    (Some(_), Some(_)) => bail!("cannot set both single and multi"),
    (None, None) => bail!("must set one of single or multi"),
    // ...
}

However, the API schema should enforce this at the type level.

🎯 Style & Code Quality

12. Unreachable Code

File: examples/system-test-actor/src/httpServer.ts:42

Code after process.exit() should be removed as it's unreachable.

13. Grammar Fix

File: sdks/api/fern/definition/builds/common.yml:33

# Current
docs: None compression.
# Should be
docs: No compression.

✅ Positive Aspects

Comprehensive Resource Management: The multi-allocation system is well-designed with proper validation
Good Error Handling: Clear error messages and proper validation throughout
Backward Compatibility: Proper handling of legacy builds
Resource Optimization: Intelligent tier selection for resource allocation
Security: Good input validation and parameterized queries

📋 Recommendations

High Priority

Fix the critical manager client bug - This will cause runtime failures
Enforce allocation type constraints at the API schema level
Add database CHECK constraints for resource values

Medium Priority

Replace serde_json::Value with proper types for better type safety
Fix integer signedness for content_length field
Add proper validation for slot counts and resource limits

Low Priority

Clean up unreachable code and grammar issues
Add comprehensive integration tests for the new allocation types
Document the resource allocation strategy for different build types

🧪 Test Coverage Assessment

Based on the code changes, the following areas need thorough testing:

Multi-actor allocation and scheduling
Resource validation edge cases
Build creation with different allocation types
Manager client protocol handling
Database migration compatibility

The PR implements a complex feature that significantly changes resource allocation behavior, so comprehensive end-to-end testing is crucial.

Overall Assessment: This is a substantial and well-architected change that introduces important multi-actor capabilities. The core logic is sound, but there are several critical and type safety issues that should be addressed before merging.

claude · 2025-07-04T01:28:02Z

Claude finished @MasterPtato's task —— View job

PR Review: Multi-Actor Support and Resource Management

Review Checklist:

Read repository guidelines and understand changes
Review API design and type safety
Examine core service logic and resource management
Check database migrations and schema changes
Analyze security implications
Review example implementations
Provide comprehensive feedback

Progress: Analysis complete, providing detailed feedback...

🐛 Critical Issues

1. Logic Bug in Manager Client (High Priority)

File: examples/system-test-actor/src/managerClient.ts:59-60

// BUG: Using packet.start_actor instead of packet.signal_actor
actor_id: packet.start_actor.actor_id,
generation: packet.start_actor.generation,

Fix:

actor_id: packet.signal_actor.actor_id,
generation: packet.signal_actor.generation,

This will cause runtime errors when signal_actor packets are received.

2. Invalid API State: Empty Allocation

File: sdks/api/fern/definition/builds/common.yml:37-40

The Allocation type allows both single and multi to be null/undefined, creating invalid states. The API should enforce that exactly one allocation type is specified.

🔧 Type Safety & Design Issues

3. Type Safety Loss with serde_json::Value

Files: Multiple SDK files use serde_json::Value for single allocation

// Current (loses type safety)
pub single: Option<serde_json::Value>,

// Better approach
pub single: Option<BuildsAllocationSingle>,

4. Signed vs Unsigned Integer Mismatch

File: sdks/api/full/rust/src/models/builds_build.rs:22

// Should be u64 as documented
pub content_length: i64, // Currently signed, should be unsigned

5. Missing Validation for Slot Count

File: sdks/api/full/rust/src/models/builds_allocation_multi.rs:17

Slot count should be positive and have reasonable limits:

pub slots: u32, // Use unsigned, add validation for min/max

⚡ Performance & Resource Management

6. Good: Proper Resource Validation

The validation logic in packages/edge/services/pegboard/src/workflows/actor2/setup.rs:94-121 correctly handles different allocation types:

Single: Requires actor-specified resources
Multi: Uses build-defined resources
None: Properly rejects old builds

7. Good: Tier-Based Resource Selection

The resource selection logic properly finds appropriate tiers and validates against available resources.

🔒 Security Assessment

8. Good: Input Validation**

Resource limits are properly validated:

CPU millicores and memory MiB checks
Tag count and size limits (max 8 tags, 32 bytes labels, 1024 bytes values)
Environment variable limits (max 64, proper size limits)

9. Good: Database Security

Database fields are properly parameterized, preventing SQL injection.

📊 Database & Migration Issues

10. Missing Constraints

File: packages/core/services/build/db/build/migrations/20250520152659_resources.up.sql

Add CHECK constraints for positive resource values:

resources_cpu_millicores INT CHECK (resources_cpu_millicores IS NULL OR resources_cpu_millicores >= 0),
resources_memory_mib INT CHECK (resources_memory_mib IS NULL OR resources_memory_mib >= 0)

🚨 API Consistency Issues

11. Allocation Logic Validation

File: packages/core/api/actor/src/route/builds.rs:396-415

The validation correctly prevents invalid states:

match (&alloc.single, &alloc.multi) {
    (Some(_), Some(_)) => bail!("cannot set both single and multi"),
    (None, None) => bail!("must set one of single or multi"),
    // ...
}

However, the API schema should enforce this at the type level.

🎯 Style & Code Quality

12. Unreachable Code

File: examples/system-test-actor/src/httpServer.ts:42

Code after process.exit() should be removed as it's unreachable.

13. Grammar Fix

File: sdks/api/fern/definition/builds/common.yml:33

# Current
docs: None compression.
# Should be
docs: No compression.

✅ Positive Aspects

Comprehensive Resource Management: The multi-allocation system is well-designed with proper validation
Good Error Handling: Clear error messages and proper validation throughout
Backward Compatibility: Proper handling of legacy builds
Resource Optimization: Intelligent tier selection for resource allocation
Security: Good input validation and parameterized queries

📋 Recommendations

High Priority

Fix the critical manager client bug - This will cause runtime failures
Enforce allocation type constraints at the API schema level
Add database CHECK constraints for resource values

Medium Priority

Replace serde_json::Value with proper types for better type safety
Fix integer signedness for content_length field
Add proper validation for slot counts and resource limits

Low Priority

Clean up unreachable code and grammar issues
Add comprehensive integration tests for the new allocation types
Document the resource allocation strategy for different build types

🧪 Test Coverage Assessment

Based on the code changes, the following areas need thorough testing:

Multi-actor allocation and scheduling
Resource validation edge cases
Build creation with different allocation types
Manager client protocol handling
Database migration compatibility

The PR implements a complex feature that significantly changes resource allocation behavior, so comprehensive end-to-end testing is crucial.

Overall Assessment: This is a substantial and well-architected change that introduces important multi-actor capabilities. The core logic is sound, but there are several critical and type safety issues that should be addressed before merging.

claude · 2025-07-11T22:30:18Z

Claude finished @MasterPtato's task —— View job

PR Review: Multi-Actor Support and Resource Management

Review Checklist:

Read repository guidelines and understand changes
Review API design and type safety
Examine core service logic and resource management
Check database migrations and schema changes
Analyze security implications
Review example implementations
Provide comprehensive feedback

Progress: Analysis complete, providing detailed feedback...

🐛 Critical Issues

1. Logic Bug in Manager Client (High Priority)

File: examples/system-test-actor/src/managerClient.ts:59-60

// BUG: Using packet.start_actor instead of packet.signal_actor
actor_id: packet.start_actor.actor_id,
generation: packet.start_actor.generation,

Fix:

actor_id: packet.signal_actor.actor_id,
generation: packet.signal_actor.generation,

This will cause runtime errors when signal_actor packets are received.

2. Invalid API State: Empty Allocation

File: sdks/api/fern/definition/builds/common.yml:37-40

The Allocation type allows both single and multi to be null/undefined, creating invalid states. The API should enforce that exactly one allocation type is specified.

🔧 Type Safety & Design Issues

3. Type Safety Loss with serde_json::Value

Files: Multiple SDK files use serde_json::Value for single allocation

// Current (loses type safety)
pub single: Option<serde_json::Value>,

// Better approach
pub single: Option<BuildsAllocationSingle>,

4. Signed vs Unsigned Integer Mismatch

File: sdks/api/full/rust/src/models/builds_build.rs:22

// Should be u64 as documented
pub content_length: i64, // Currently signed, should be unsigned

5. Missing Validation for Slot Count

File: sdks/api/full/rust/src/models/builds_allocation_multi.rs:17

Slot count should be positive and have reasonable limits:

pub slots: u32, // Use unsigned, add validation for min/max

⚡ Performance & Resource Management

6. Good: Proper Resource Validation

The validation logic in packages/edge/services/pegboard/src/workflows/actor2/setup.rs:94-121 correctly handles different allocation types:

Single: Requires actor-specified resources
Multi: Uses build-defined resources
None: Properly rejects old builds

7. Good: Tier-Based Resource Selection

The resource selection logic properly finds appropriate tiers and validates against available resources.

🔒 Security Assessment

8. Good: Input Validation**

Resource limits are properly validated:

CPU millicores and memory MiB checks
Tag count and size limits (max 8 tags, 32 bytes labels, 1024 bytes values)
Environment variable limits (max 64, proper size limits)

9. Good: Database Security

Database fields are properly parameterized, preventing SQL injection.

📊 Database & Migration Issues

10. Missing Constraints

File: packages/edge/services/pegboard/src/workflows/actor2/migrations.rs:27

Add CHECK constraints for positive resource values:

resources_cpu_millicores INT CHECK (resources_cpu_millicores IS NULL OR resources_cpu_millicores >= 0),
resources_memory_mib INT CHECK (resources_memory_mib IS NULL OR resources_memory_mib >= 0)

🚨 API Consistency Issues

11. Allocation Logic Validation

File: packages/core/api/actor/src/route/builds.rs:396-415

The validation correctly prevents invalid states:

match (&alloc.single, &alloc.multi) {
    (Some(_), Some(_)) => bail!("cannot set both single and multi"),
    (None, None) => bail!("must set one of single or multi"),
    // ...
}

However, the API schema should enforce this at the type level.

🎯 Style & Code Quality

12. Unreachable Code

File: examples/system-test-actor/src/httpServer.ts:42

Code after process.exit() should be removed as it's unreachable.

13. Grammar Fix

File: sdks/api/fern/definition/builds/common.yml:33

# Current
docs: None compression.
# Should be
docs: No compression.

✅ Positive Aspects

Comprehensive Resource Management: The multi-allocation system is well-designed with proper validation
Good Error Handling: Clear error messages and proper validation throughout
Backward Compatibility: Proper handling of legacy builds
Resource Optimization: Intelligent tier selection for resource allocation
Security: Good input validation and parameterized queries

📋 Recommendations

High Priority

Fix the critical manager client bug - This will cause runtime failures
Enforce allocation type constraints at the API schema level
Add database CHECK constraints for resource values

Medium Priority

Replace serde_json::Value with proper types for better type safety
Fix integer signedness for content_length field
Add proper validation for slot counts and resource limits

Low Priority

Clean up unreachable code and grammar issues
Add comprehensive integration tests for the new allocation types
Document the resource allocation strategy for different build types

🧪 Test Coverage Assessment

Based on the code changes, the following areas need thorough testing:

Multi-actor allocation and scheduling
Resource validation edge cases
Build creation with different allocation types
Manager client protocol handling
Database migration compatibility

The PR implements a complex feature that significantly changes resource allocation behavior, so comprehensive end-to-end testing is crucial.

Overall Assessment: This is a substantial and well-architected change that introduces important multi-actor capabilities. The core logic is sound, but there are several critical and type safety issues that should be addressed before merging.

claude · 2025-07-11T22:30:22Z

Claude finished @MasterPtato's task —— View job

PR Review: Multi-Actor Support and Resource Management

Review Checklist:

Read repository guidelines and understand changes
Review API design and type safety
Examine core service logic and resource management
Check database migrations and schema changes
Analyze security implications
Review example implementations
Provide comprehensive feedback

Progress: Analysis complete, providing detailed feedback...

🐛 Critical Issues

1. Logic Bug in Manager Client (High Priority)

File: examples/system-test-actor/src/managerClient.ts:59-60

// BUG: Using packet.start_actor instead of packet.signal_actor
actor_id: packet.start_actor.actor_id,
generation: packet.start_actor.generation,

Fix:

actor_id: packet.signal_actor.actor_id,
generation: packet.signal_actor.generation,

This will cause runtime errors when signal_actor packets are received.

2. Invalid API State: Empty Allocation

File: sdks/api/fern/definition/builds/common.yml:37-40

The Allocation type allows both single and multi to be null/undefined, creating invalid states. The API should enforce that exactly one allocation type is specified.

🔧 Type Safety & Design Issues

3. Type Safety Loss with serde_json::Value

Files: Multiple SDK files use serde_json::Value for single allocation

// Current (loses type safety)
pub single: Option<serde_json::Value>,

// Better approach
pub single: Option<BuildsAllocationSingle>,

4. Signed vs Unsigned Integer Mismatch

File: sdks/api/full/rust/src/models/builds_build.rs:22

// Should be u64 as documented
pub content_length: i64, // Currently signed, should be unsigned

5. Missing Validation for Slot Count

File: sdks/api/full/rust/src/models/builds_allocation_multi.rs:17

Slot count should be positive and have reasonable limits:

pub slots: u32, // Use unsigned, add validation for min/max

⚡ Performance & Resource Management

6. Good: Proper Resource Validation

The validation logic in packages/edge/services/pegboard/src/workflows/actor2/setup.rs:94-121 correctly handles different allocation types:

Single: Requires actor-specified resources
Multi: Uses build-defined resources
None: Properly rejects old builds

7. Good: Tier-Based Resource Selection

The resource selection logic properly finds appropriate tiers and validates against available resources.

🔒 Security Assessment

8. Good: Input Validation**

Resource limits are properly validated:

CPU millicores and memory MiB checks
Tag count and size limits (max 8 tags, 32 bytes labels, 1024 bytes values)
Environment variable limits (max 64, proper size limits)

9. Good: Database Security

Database fields are properly parameterized, preventing SQL injection.

📊 Database & Migration Issues

10. Missing Constraints

File: packages/edge/services/pegboard/src/workflows/actor2/migrations.rs:27

Add CHECK constraints for positive resource values:

resources_cpu_millicores INT CHECK (resources_cpu_millicores IS NULL OR resources_cpu_millicores >= 0),
resources_memory_mib INT CHECK (resources_memory_mib IS NULL OR resources_memory_mib >= 0)

🚨 API Consistency Issues

11. Allocation Logic Validation

File: packages/core/api/actor/src/route/builds.rs:396-415

The validation correctly prevents invalid states:

match (&alloc.single, &alloc.multi) {
    (Some(_), Some(_)) => bail!("cannot set both single and multi"),
    (None, None) => bail!("must set one of single or multi"),
    // ...
}

However, the API schema should enforce this at the type level.

🎯 Style & Code Quality

12. Unreachable Code

File: examples/system-test-actor/src/httpServer.ts:42

Code after process.exit() should be removed as it's unreachable.

13. Grammar Fix

File: sdks/api/fern/definition/builds/common.yml:33

# Current
docs: None compression.
# Should be
docs: No compression.

✅ Positive Aspects

Comprehensive Resource Management: The multi-allocation system is well-designed with proper validation
Good Error Handling: Clear error messages and proper validation throughout
Backward Compatibility: Proper handling of legacy builds
Resource Optimization: Intelligent tier selection for resource allocation
Security: Good input validation and parameterized queries

📋 Recommendations

High Priority

Fix the critical manager client bug - This will cause runtime failures
Enforce allocation type constraints at the API schema level
Add database CHECK constraints for resource values

Medium Priority

Replace serde_json::Value with proper types for better type safety
Fix integer signedness for content_length field
Add proper validation for slot counts and resource limits

Low Priority

Clean up unreachable code and grammar issues
Add comprehensive integration tests for the new allocation types
Document the resource allocation strategy for different build types

🧪 Test Coverage Assessment

Based on the code changes, the following areas need thorough testing:

Multi-actor allocation and scheduling
Resource validation edge cases
Build creation with different allocation types
Manager client protocol handling
Database migration compatibility

The PR implements a complex feature that significantly changes resource allocation behavior, so comprehensive end-to-end testing is crucial.

Overall Assessment: This is a substantial and well-architected change that introduces important multi-actor capabilities. The core logic is sound, but there are several critical and type safety issues that should be addressed before merging.

claude · 2025-07-12T00:44:24Z

Claude finished @MasterPtato's task —— View job

PR Review: Multi-Actor Support and Resource Management

Review Checklist:

Read repository guidelines and understand changes
Review API design and type safety
Examine core service logic and resource management
Check database migrations and schema changes
Analyze security implications
Review example implementations
Provide comprehensive feedback

Progress: Analysis complete, providing detailed feedback...

🐛 Critical Issues

1. Logic Bug in Manager Client (High Priority)

File: examples/system-test-actor/src/managerClient.ts:59-60

// BUG: Using packet.start_actor instead of packet.signal_actor
actor_id: packet.start_actor.actor_id,
generation: packet.start_actor.generation,

Fix:

actor_id: packet.signal_actor.actor_id,
generation: packet.signal_actor.generation,

This will cause runtime errors when signal_actor packets are received.

2. Invalid API State: Empty Allocation

File: sdks/api/fern/definition/builds/common.yml:37-40

The Allocation type allows both single and multi to be null/undefined, creating invalid states. The API should enforce that exactly one allocation type is specified.

🔧 Type Safety & Design Issues

3. Type Safety Loss with serde_json::Value

Files: Multiple SDK files use serde_json::Value for single allocation

// Current (loses type safety)
pub single: Option<serde_json::Value>,

// Better approach
pub single: Option<BuildsAllocationSingle>,

4. Signed vs Unsigned Integer Mismatch

File: sdks/api/full/rust/src/models/builds_build.rs:22

// Should be u64 as documented
pub content_length: i64, // Currently signed, should be unsigned

5. Missing Validation for Slot Count

File: sdks/api/full/rust/src/models/builds_allocation_multi.rs:17

Slot count should be positive and have reasonable limits:

pub slots: u32, // Use unsigned, add validation for min/max

⚡ Performance & Resource Management

6. Good: Proper Resource Validation

The validation logic in packages/edge/services/pegboard/src/workflows/actor2/setup.rs:94-121 correctly handles different allocation types:

Single: Requires actor-specified resources
Multi: Uses build-defined resources
None: Properly rejects old builds

7. Good: Tier-Based Resource Selection

The resource selection logic properly finds appropriate tiers and validates against available resources.

🔒 Security Assessment

8. Good: Input Validation**

Resource limits are properly validated:

CPU millicores and memory MiB checks
Tag count and size limits (max 8 tags, 32 bytes labels, 1024 bytes values)
Environment variable limits (max 64, proper size limits)

9. Good: Database Security

Database fields are properly parameterized, preventing SQL injection.

📊 Database & Migration Issues

10. Missing Constraints

File: packages/edge/services/pegboard/src/workflows/actor2/migrations.rs:27

Add CHECK constraints for positive resource values:

resources_cpu_millicores INT CHECK (resources_cpu_millicores IS NULL OR resources_cpu_millicores >= 0),
resources_memory_mib INT CHECK (resources_memory_mib IS NULL OR resources_memory_mib >= 0)

🚨 API Consistency Issues

11. Allocation Logic Validation

File: packages/core/api/actor/src/route/builds.rs:396-415

The validation correctly prevents invalid states:

match (&alloc.single, &alloc.multi) {
    (Some(_), Some(_)) => bail!("cannot set both single and multi"),
    (None, None) => bail!("must set one of single or multi"),
    // ...
}

However, the API schema should enforce this at the type level.

🎯 Style & Code Quality

12. Unreachable Code

File: examples/system-test-actor/src/httpServer.ts:42

Code after process.exit() should be removed as it's unreachable.

13. Grammar Fix

File: sdks/api/fern/definition/builds/common.yml:33

# Current
docs: None compression.
# Should be
docs: No compression.

✅ Positive Aspects

Comprehensive Resource Management: The multi-allocation system is well-designed with proper validation
Good Error Handling: Clear error messages and proper validation throughout
Backward Compatibility: Proper handling of legacy builds
Resource Optimization: Intelligent tier selection for resource allocation
Security: Good input validation and parameterized queries

📋 Recommendations

High Priority

Fix the critical manager client bug - This will cause runtime failures
Enforce allocation type constraints at the API schema level
Add database CHECK constraints for resource values

Medium Priority

Replace serde_json::Value with proper types for better type safety
Fix integer signedness for content_length field
Add proper validation for slot counts and resource limits

Low Priority

Clean up unreachable code and grammar issues
Add comprehensive integration tests for the new allocation types
Document the resource allocation strategy for different build types

🧪 Test Coverage Assessment

Based on the code changes, the following areas need thorough testing:

Multi-actor allocation and scheduling
Resource validation edge cases
Build creation with different allocation types
Manager client protocol handling
Database migration compatibility

The PR implements a complex feature that significantly changes resource allocation behavior, so comprehensive end-to-end testing is crucial.

Overall Assessment: This is a substantial and well-architected change that introduces important multi-actor capabilities. The core logic is sound, but there are several critical and type safety issues that should be addressed before merging.

claude · 2025-07-12T00:45:33Z

Claude finished @MasterPtato's task —— View job

PR Review: Multi-Actor Support and Resource Management

Review Checklist:

Read repository guidelines and understand changes
Review API design and type safety
Examine core service logic and resource management
Check database migrations and schema changes
Analyze security implications
Review example implementations
Provide comprehensive feedback

Progress: Analysis complete, providing detailed feedback...

🐛 Critical Issues

1. Logic Bug in Manager Client (High Priority)

File: examples/system-test-actor/src/managerClient.ts:59-60

// BUG: Using packet.start_actor instead of packet.signal_actor
actor_id: packet.start_actor.actor_id,
generation: packet.start_actor.generation,

Fix:

actor_id: packet.signal_actor.actor_id,
generation: packet.signal_actor.generation,

This will cause runtime errors when signal_actor packets are received.

2. Invalid API State: Empty Allocation

File: sdks/api/fern/definition/builds/common.yml:37-40

The Allocation type allows both single and multi to be null/undefined, creating invalid states. The API should enforce that exactly one allocation type is specified.

🔧 Type Safety & Design Issues

3. Type Safety Loss with serde_json::Value

Files: Multiple SDK files use serde_json::Value for single allocation

// Current (loses type safety)
pub single: Option<serde_json::Value>,

// Better approach
pub single: Option<BuildsAllocationSingle>,

4. Signed vs Unsigned Integer Mismatch

File: sdks/api/full/rust/src/models/builds_build.rs:22

// Should be u64 as documented
pub content_length: i64, // Currently signed, should be unsigned

5. Missing Validation for Slot Count

File: sdks/api/full/rust/src/models/builds_allocation_multi.rs:17

Slot count should be positive and have reasonable limits:

pub slots: u32, // Use unsigned, add validation for min/max

⚡ Performance & Resource Management

6. Good: Proper Resource Validation

The validation logic in packages/edge/services/pegboard/src/workflows/actor2/setup.rs:94-121 correctly handles different allocation types:

Single: Requires actor-specified resources
Multi: Uses build-defined resources
None: Properly rejects old builds

7. Good: Tier-Based Resource Selection

The resource selection logic properly finds appropriate tiers and validates against available resources.

🔒 Security Assessment

8. Good: Input Validation**

Resource limits are properly validated:

CPU millicores and memory MiB checks
Tag count and size limits (max 8 tags, 32 bytes labels, 1024 bytes values)
Environment variable limits (max 64, proper size limits)

9. Good: Database Security

Database fields are properly parameterized, preventing SQL injection.

📊 Database & Migration Issues

10. Missing Constraints

File: packages/edge/services/pegboard/src/workflows/actor2/migrations.rs:27

Add CHECK constraints for positive resource values:

resources_cpu_millicores INT CHECK (resources_cpu_millicores IS NULL OR resources_cpu_millicores >= 0),
resources_memory_mib INT CHECK (resources_memory_mib IS NULL OR resources_memory_mib >= 0)

🚨 API Consistency Issues

11. Allocation Logic Validation

File: packages/core/api/actor/src/route/builds.rs:396-415

The validation correctly prevents invalid states:

match (&alloc.single, &alloc.multi) {
    (Some(_), Some(_)) => bail!("cannot set both single and multi"),
    (None, None) => bail!("must set one of single or multi"),
    // ...
}

However, the API schema should enforce this at the type level.

🎯 Style & Code Quality

12. Unreachable Code

File: examples/system-test-actor/src/httpServer.ts:42

Code after process.exit() should be removed as it's unreachable.

13. Grammar Fix

File: sdks/api/fern/definition/builds/common.yml:33

# Current
docs: None compression.
# Should be
docs: No compression.

✅ Positive Aspects

Comprehensive Resource Management: The multi-allocation system is well-designed with proper validation
Good Error Handling: Clear error messages and proper validation throughout
Backward Compatibility: Proper handling of legacy builds
Resource Optimization: Intelligent tier selection for resource allocation
Security: Good input validation and parameterized queries

📋 Recommendations

High Priority

Fix the critical manager client bug - This will cause runtime failures
Enforce allocation type constraints at the API schema level
Add database CHECK constraints for resource values

Medium Priority

Replace serde_json::Value with proper types for better type safety
Fix integer signedness for content_length field
Add proper validation for slot counts and resource limits

Low Priority

Clean up unreachable code and grammar issues
Add comprehensive integration tests for the new allocation types
Document the resource allocation strategy for different build types

🧪 Test Coverage Assessment

Based on the code changes, the following areas need thorough testing:

Multi-actor allocation and scheduling
Resource validation edge cases
Build creation with different allocation types
Manager client protocol handling
Database migration compatibility

The PR implements a complex feature that significantly changes resource allocation behavior, so comprehensive end-to-end testing is crucial.

Overall Assessment: This is a substantial and well-architected change that introduces important multi-actor capabilities. The core logic is sound, but there are several critical and type safety issues that should be addressed before merging.

vercel · 2025-07-18T18:51:29Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-site	Error			Aug 21, 2025 8:41pm

claude · 2025-07-18T18:52:02Z

Claude finished @MasterPtato's task —— View job

PR Review: Multi-Actor Support and Resource Management

Review Checklist:

Read repository guidelines and understand changes
Review API design and type safety
Examine core service logic and resource management
Check database migrations and schema changes
Analyze security implications
Review example implementations
Provide comprehensive feedback

Progress: Analysis complete, providing detailed feedback...

🐛 Critical Issues

1. Logic Bug in Manager Client (High Priority)

File: examples/system-test-actor/src/managerClient.ts:59-60

// BUG: Using packet.start_actor instead of packet.signal_actor
actor_id: packet.start_actor.actor_id,
generation: packet.start_actor.generation,

Fix:

actor_id: packet.signal_actor.actor_id,
generation: packet.signal_actor.generation,

This will cause runtime errors when signal_actor packets are received.

2. Invalid API State: Empty Allocation

File: sdks/api/fern/definition/builds/common.yml:37-40

The Allocation type allows both single and multi to be null/undefined, creating invalid states. The API should enforce that exactly one allocation type is specified.

🔧 Type Safety & Design Issues

3. Type Safety Loss with serde_json::Value

Files: Multiple SDK files use serde_json::Value for single allocation

// Current (loses type safety)
pub single: Option<serde_json::Value>,

// Better approach
pub single: Option<BuildsAllocationSingle>,

4. Signed vs Unsigned Integer Mismatch

File: sdks/api/full/rust/src/models/builds_build.rs:22

// Should be u64 as documented
pub content_length: i64, // Currently signed, should be unsigned

5. Missing Validation for Slot Count

File: sdks/api/full/rust/src/models/builds_allocation_multi.rs:17

Slot count should be positive and have reasonable limits:

pub slots: u32, // Use unsigned, add validation for min/max

⚡ Performance & Resource Management

6. Good: Proper Resource Validation

The validation logic in packages/edge/services/pegboard/src/workflows/actor2/setup.rs:94-121 correctly handles different allocation types:

Single: Requires actor-specified resources
Multi: Uses build-defined resources
None: Properly rejects old builds

7. Good: Tier-Based Resource Selection

The resource selection logic properly finds appropriate tiers and validates against available resources.

🔒 Security Assessment

8. Good: Input Validation**

Resource limits are properly validated:

CPU millicores and memory MiB checks
Tag count and size limits (max 8 tags, 32 bytes labels, 1024 bytes values)
Environment variable limits (max 64, proper size limits)

9. Good: Database Security

Database fields are properly parameterized, preventing SQL injection.

📊 Database & Migration Issues

10. Missing Constraints

File: packages/edge/services/pegboard/src/workflows/actor2/migrations.rs:27

Add CHECK constraints for positive resource values:

resources_cpu_millicores INT CHECK (resources_cpu_millicores IS NULL OR resources_cpu_millicores >= 0),
resources_memory_mib INT CHECK (resources_memory_mib IS NULL OR resources_memory_mib >= 0)

🚨 API Consistency Issues

11. Allocation Logic Validation

File: packages/core/api/actor/src/route/builds.rs:396-415

The validation correctly prevents invalid states:

match (&alloc.single, &alloc.multi) {
    (Some(_), Some(_)) => bail!("cannot set both single and multi"),
    (None, None) => bail!("must set one of single or multi"),
    // ...
}

However, the API schema should enforce this at the type level.

🎯 Style & Code Quality

12. Unreachable Code

File: examples/system-test-actor/src/httpServer.ts:42

Code after process.exit() should be removed as it's unreachable.

13. Grammar Fix

File: sdks/api/fern/definition/builds/common.yml:33

# Current
docs: None compression.
# Should be
docs: No compression.

✅ Positive Aspects

Comprehensive Resource Management: The multi-allocation system is well-designed with proper validation
Good Error Handling: Clear error messages and proper validation throughout
Backward Compatibility: Proper handling of legacy builds
Resource Optimization: Intelligent tier selection for resource allocation
Security: Good input validation and parameterized queries

📋 Recommendations

High Priority

Fix the critical manager client bug - This will cause runtime failures
Enforce allocation type constraints at the API schema level
Add database CHECK constraints for resource values

Medium Priority

Replace serde_json::Value with proper types for better type safety
Fix integer signedness for content_length field
Add proper validation for slot counts and resource limits

Low Priority

Clean up unreachable code and grammar issues
Add comprehensive integration tests for the new allocation types
Document the resource allocation strategy for different build types

🧪 Test Coverage Assessment

Based on the code changes, the following areas need thorough testing:

Multi-actor allocation and scheduling
Resource validation edge cases
Build creation with different allocation types
Manager client protocol handling
Database migration compatibility

The PR implements a complex feature that significantly changes resource allocation behavior, so comprehensive end-to-end testing is crucial.

Overall Assessment: This is a substantial and well-architected change that introduces important multi-actor capabilities. The core logic is sound, but there are several critical and type safety issues that should be addressed before merging.

claude · 2025-07-18T18:58:55Z

Claude finished @MasterPtato's task —— View job

PR Review: Multi-Actor Support and Resource Management

Review Checklist:

Read repository guidelines and understand changes
Review API design and type safety
Examine core service logic and resource management
Check database migrations and schema changes
Analyze security implications
Review example implementations
Provide comprehensive feedback

Progress: Analysis complete, providing detailed feedback...

🐛 Critical Issues

1. Logic Bug in Manager Client (High Priority)

File: examples/system-test-actor/src/managerClient.ts:59-60

// BUG: Using packet.start_actor instead of packet.signal_actor
actor_id: packet.start_actor.actor_id,
generation: packet.start_actor.generation,

Fix:

actor_id: packet.signal_actor.actor_id,
generation: packet.signal_actor.generation,

This will cause runtime errors when signal_actor packets are received.

2. Invalid API State: Empty Allocation

File: sdks/api/fern/definition/builds/common.yml:37-40

The Allocation type allows both single and multi to be null/undefined, creating invalid states. The API should enforce that exactly one allocation type is specified.

🔧 Type Safety & Design Issues

3. Type Safety Loss with serde_json::Value

Files: Multiple SDK files use serde_json::Value for single allocation

// Current (loses type safety)
pub single: Option<serde_json::Value>,

// Better approach
pub single: Option<BuildsAllocationSingle>,

4. Signed vs Unsigned Integer Mismatch

File: sdks/api/full/rust/src/models/builds_build.rs:22

// Should be u64 as documented
pub content_length: i64, // Currently signed, should be unsigned

5. Missing Validation for Slot Count

File: sdks/api/full/rust/src/models/builds_allocation_multi.rs:17

Slot count should be positive and have reasonable limits:

pub slots: u32, // Use unsigned, add validation for min/max

⚡ Performance & Resource Management

6. Good: Proper Resource Validation

The validation logic in packages/edge/services/pegboard/src/workflows/actor2/setup.rs:94-121 correctly handles different allocation types:

Single: Requires actor-specified resources
Multi: Uses build-defined resources
None: Properly rejects old builds

7. Good: Tier-Based Resource Selection

The resource selection logic properly finds appropriate tiers and validates against available resources.

🔒 Security Assessment

8. Good: Input Validation**

Resource limits are properly validated:

CPU millicores and memory MiB checks
Tag count and size limits (max 8 tags, 32 bytes labels, 1024 bytes values)
Environment variable limits (max 64, proper size limits)

9. Good: Database Security

Database fields are properly parameterized, preventing SQL injection.

📊 Database & Migration Issues

10. Missing Constraints

File: packages/core/services/build/db/build/migrations/20250520152659_resources.up.sql

Add CHECK constraints for positive resource values:

resources_cpu_millicores INT CHECK (resources_cpu_millicores IS NULL OR resources_cpu_millicores >= 0),
resources_memory_mib INT CHECK (resources_memory_mib IS NULL OR resources_memory_mib >= 0)

🚨 API Consistency Issues

11. Allocation Logic Validation

File: packages/core/api/actor/src/route/builds.rs:396-415

The validation correctly prevents invalid states:

match (&alloc.single, &alloc.multi) {
    (Some(_), Some(_)) => bail!("cannot set both single and multi"),
    (None, None) => bail!("must set one of single or multi"),
    // ...
}

However, the API schema should enforce this at the type level.

🎯 Style & Code Quality

12. Unreachable Code

File: examples/system-test-actor/src/httpServer.ts:42

Code after process.exit() should be removed as it's unreachable.

13. Grammar Fix

File: sdks/api/fern/definition/builds/common.yml:33

# Current
docs: None compression.
# Should be
docs: No compression.

✅ Positive Aspects

Comprehensive Resource Management: The multi-allocation system is well-designed with proper validation
Good Error Handling: Clear error messages and proper validation throughout
Backward Compatibility: Proper handling of legacy builds
Resource Optimization: Intelligent tier selection for resource allocation
Security: Good input validation and parameterized queries

📋 Recommendations

High Priority

Fix the critical manager client bug - This will cause runtime failures
Enforce allocation type constraints at the API schema level
Add database CHECK constraints for resource values

Medium Priority

Replace serde_json::Value with proper types for better type safety
Fix integer signedness for content_length field
Add proper validation for slot counts and resource limits

Low Priority

Clean up unreachable code and grammar issues
Add comprehensive integration tests for the new allocation types
Document the resource allocation strategy for different build types

🧪 Test Coverage Assessment

Based on the code changes, the following areas need thorough testing:

Multi-actor allocation and scheduling
Resource validation edge cases
Build creation with different allocation types
Manager client protocol handling
Database migration compatibility

The PR implements a complex feature that significantly changes resource allocation behavior, so comprehensive end-to-end testing is crucial.

Overall Assessment: This is a substantial and well-architected change that introduces important multi-actor capabilities. The core logic is sound, but there are several critical and type safety issues that should be addressed before merging.

claude · 2025-08-21T20:13:20Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-08-21T20:13:21Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

MasterPtato requested a review from NathanFlurry May 21, 2025 01:38

This was referenced May 21, 2025

feat(pb): add runner logs #2447

Closed

fix(pegboard): fix netns path bug #2431

Closed

fix: swap status monitor dns resolver with native resolver #2432

Closed

feat: add runners to pb protocol #2433

Closed

greptile-apps bot reviewed May 21, 2025

View reviewed changes

This was referenced May 22, 2025

feat: implement new actor ids #2467

Closed

fix(pb): get new actor ids working e2e #2471

Closed

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from 9b820e0 to ed03e29 Compare May 27, 2025 02:02

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from d94da15 to 14ec025 Compare May 27, 2025 02:02

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from ed03e29 to 869e278 Compare June 17, 2025 18:39

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from 14ec025 to 6a71c38 Compare June 17, 2025 18:39

MasterPtato mentioned this pull request Jul 4, 2025

fix: convert runner protocol to protobuf #2702

Closed

This was referenced Jul 4, 2025

fix: even more actor api changes #2714

Closed

fix: get pb manager test working e2e again #2721

Closed

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from f54d281 to c170c16 Compare July 11, 2025 22:23

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from 9750b18 to 459a987 Compare July 11, 2025 22:23

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from c170c16 to f028f0c Compare July 12, 2025 00:40

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from 459a987 to 355ea0f Compare July 12, 2025 00:40

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from f028f0c to ec0407c Compare July 18, 2025 18:51

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from 355ea0f to 4d16edc Compare July 18, 2025 18:51

vercel bot had a problem deploying to Preview July 18, 2025 19:35 Failure

feat(pb): get multi-actors working e2e, add resources for builds

0a4329c

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from ec0407c to 3b7227e Compare August 21, 2025 20:12

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from 4d16edc to 0a4329c Compare August 21, 2025 20:12

This was referenced Aug 21, 2025

fix: make query_as macros retry #2773

Closed

fix: clean up worker threads in the event of an error #2783

Closed

fix: make pb image downloads random, remove prewarm from pb protocol #2784

Closed

vercel bot had a problem deploying to Preview August 21, 2025 20:41 Failure

NathanFlurry closed this Sep 8, 2025

		const server = serve({ fetch: app.fetch, port });
		injectWebSocket(server);




		#[derive(Clone, Debug, PartialEq, Default, Serialize, Deserialize)]


		createAndStartUdpServer();

		if (process.env.MULTI) {

feat(pb): get multi-actors working e2e, add resources for builds #2465

feat(pb): get multi-actors working e2e, add resources for builds #2465

Uh oh!

Conversation

MasterPtato commented May 21, 2025

Changes

Uh oh!

MasterPtato commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

cloudflare-workers-and-pages bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-studio with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-hub with Cloudflare Pages

Uh oh!

coderabbitai bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

claude bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: Multi-Actor Support and Resource Management

🐛 Critical Issues

1. Logic Bug in Manager Client (High Priority)

2. Invalid API State: Empty Allocation

🔧 Type Safety & Design Issues

3. Type Safety Loss with serde_json::Value

4. Signed vs Unsigned Integer Mismatch

5. Missing Validation for Slot Count

⚡ Performance & Resource Management

6. Good: Proper Resource Validation

7. Good: Tier-Based Resource Selection

MasterPtato commented May 21, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented May 21, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented May 27, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented May 27, 2025 •

edited

Loading

coderabbitai bot commented Jul 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

claude bot commented Jul 4, 2025 •

edited

Loading

claude bot commented Jul 4, 2025 •

edited

Loading

claude bot commented Jul 11, 2025 •

edited

Loading