fix(langserver): corrected document_symbols when matching keyword or test case declaration when no name is given

fixes #377

Author: d-biehl

packages/language_server/src/robotcode/language_server/robotframework/parts/document_symbols.py

@@ -87,7 +87,7 @@ def visit_Section(self, node: Section) -> None:  # noqa: N802
         self.generic_visit_current_symbol(node, symbol)
 
     def visit_TestCase(self, node: TestCase) -> None:  # noqa: N802
-        if node.name is None:
+        if not node.name:
             return
 
         if self.current_symbol is not None and self.current_symbol.children is not None:
@@ -104,7 +104,7 @@ def visit_TestCase(self, node: TestCase) -> None:  # noqa: N802
             self.generic_visit_current_symbol(node, symbol)
 
     def visit_Keyword(self, node: Keyword) -> None:  # noqa: N802
-        if node.name is None:
+        if not node.name:
             return
 
         if self.current_symbol is not None and self.current_symbol.children is not None:

tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf41/test_document_symbols.test[symbols.robot-044-001-another_keywords_section].out

@@ -10,15 +10,15 @@ result: !DocumentSymbol
   name: Keywords
   range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 44
   selection_range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 44

tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf41/test_document_symbols.test[symbols.robot-044-008-another_keywords_section].out

@@ -10,15 +10,15 @@ result: !DocumentSymbol
   name: Keywords
   range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 44
   selection_range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 44

tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf41/test_document_symbols.test[symbols.robot-044-015-another_keywords_section].out

@@ -10,15 +10,15 @@ result: !DocumentSymbol
   name: Keywords
   range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 44
   selection_range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 44

tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf41/test_document_symbols.test[symbols.robot-046-001-another_keyword].out

@@ -10,15 +10,15 @@ result: !DocumentSymbol
   name: another keyword
   range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 46
   selection_range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 46

tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf41/test_document_symbols.test[symbols.robot-046-008-another_keyword].out

@@ -10,15 +10,15 @@ result: !DocumentSymbol
   name: another keyword
   range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 46
   selection_range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 46

tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf41/test_document_symbols.test[symbols.robot-046-014-another_keyword].out

@@ -10,15 +10,15 @@ result: !DocumentSymbol
   name: another keyword
   range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 46
   selection_range:
     end:
-      character: 16
-      line: 49
+      character: 1
+      line: 50
     start:
       character: 0
       line: 46

tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf41/test_document_symbols.test[symbols.robot-052-001-unreachable_test].out

@@ -0,0 +1,25 @@
+data: !GeneratedTestData
+  character: 1
+  line: 52
+  name: unreachable test
+result: !DocumentSymbol
+  children: []
+  deprecated: null
+  detail: null
+  kind: 2
+  name: Test Cases
+  range:
+    end:
+      character: 1
+      line: 55
+    start:
+      character: 0
+      line: 51
+  selection_range:
+    end:
+      character: 1
+      line: 55
+    start:
+      character: 0
+      line: 51
+  tags: null

tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf41/test_document_symbols.test[symbols.robot-052-002-unreachable_test].out

@@ -0,0 +1,25 @@
+data: !GeneratedTestData
+  character: 2
+  line: 52
+  name: unreachable test
+result: !DocumentSymbol
+  children: []
+  deprecated: null
+  detail: null
+  kind: 2
+  name: Test Cases
+  range:
+    end:
+      character: 1
+      line: 55
+    start:
+      character: 0
+      line: 51
+  selection_range:
+    end:
+      character: 1
+      line: 55
+    start:
+      character: 0
+      line: 51
+  tags: null

tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf41/test_document_symbols.test[symbols.robot-052-003-unreachable_test].out

@@ -0,0 +1,25 @@
+data: !GeneratedTestData
+  character: 3
+  line: 52
+  name: unreachable test
+result: !DocumentSymbol
+  children: []
+  deprecated: null
+  detail: null
+  kind: 2
+  name: Test Cases
+  range:
+    end:
+      character: 1
+      line: 55
+    start:
+      character: 0
+      line: 51
+  selection_range:
+    end:
+      character: 1
+      line: 55
+    start:
+      character: 0
+      line: 51
+  tags: null