Skip to content

Commit 149dfe9

Browse files
committed
build: fix release missing coordinates and add android.quality.gradle
1 parent 82db09a commit 149dfe9

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

build-logic/conventions/src/main/kotlin/RollbarPublishPlugin.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,12 @@ class RollbarPublishPlugin : Plugin<Project> {
1919
project.plugins.apply("com.vanniktech.maven.publish")
2020

2121
project.extensions.configure(MavenPublishBaseExtension::class.java) {
22+
coordinates(
23+
groupId = project.findProperty("GROUP") as String,
24+
artifactId = project.name,
25+
version = project.findProperty("VERSION_NAME") as String,
26+
)
27+
2228
pom {
2329
name.set(project.findProperty("POM_NAME") as String)
2430
description.set(project.findProperty("POM_DESCRIPTION") as String)
@@ -55,7 +61,6 @@ class RollbarPublishPlugin : Plugin<Project> {
5561
}
5662

5763
publishToMavenCentral()
58-
signAllPublications()
5964
}
6065
}
6166
}

build.gradle.kts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,16 @@ subprojects {
2121
val isExample = name.contains("examples") || parent?.name == "examples"
2222
val isAndroid = name.contains("android")
2323

24-
if (isExample || isAndroid) {
24+
if (isExample) {
2525
return@subprojects
2626
}
2727

28-
apply(plugin = "java-library")
2928
apply(plugin = "com.rollbar.conventions.release")
29+
if (isAndroid) {
30+
return@subprojects
31+
}
32+
33+
apply(plugin = "java-library")
3034
apply(from = "$rootDir/gradle/quality.gradle")
3135
apply(from = "$rootDir/gradle/compatibility.gradle")
3236

rollbar-android/build.gradle.kts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
plugins {
22
id("com.android.library")
3-
id("com.rollbar.conventions.release")
43
}
54

6-
//apply(from = "$rootDir/gradle/android.quality.gradle") //TODO: Update as convention plugin
5+
apply(from = "$rootDir/gradle/android.quality.gradle")
76

87
android {
98
namespace = "com.rollbar.android"

0 commit comments

Comments
 (0)