Skip to content

Conversation

@KoljaFrahm
Copy link
Contributor

@KoljaFrahm KoljaFrahm commented Nov 9, 2025

This Pull request:

Adds the option of exporting auxiliary of TGeoVolumes in TGDMLWrite
Uses same format as in https://github.com/root-project/root/blob/master/geom/gdml/src/TGDMLParse.cxx

Changes or fixes:

Fixes #20356

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #20356

@KoljaFrahm
Copy link
Contributor Author

I reformatted my commit (clang), do I still have to do so something to start the tests again?

@dpiparo
Copy link
Member

dpiparo commented Nov 12, 2025

Is there a way in which we could test this fix?

@KoljaFrahm
Copy link
Contributor Author

KoljaFrahm commented Nov 12, 2025

I described two ways in the issues (Reproducer).
Is this enough or should I describe something in more detail?

@KoljaFrahm
Copy link
Contributor Author

I am not sure why the ruff code analysis fails for files I haven't changed

Copy link
Member

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KoljaFrahm for this addition - reading the auxiliary data via TGDMLParse was only intended so far to provide user access to these data via the volume user extensions, but it is indeed nice to be able to re-export it. See my comment requesting a small correction - otherwise your patch works nicely!

@agheata
Copy link
Member

agheata commented Nov 12, 2025

Is there a way in which we could test this fix?

Actually, this is not a fix but a feature, allowing the re-export of GDML auxiliary volume data imported from a GDML file. It could be tested eventually if we make a more general GDML import/export regression test

This adds the option of exporting auxiliary of TGeoVolumes in TGDMLWrite
Fixes root-project#20356
@KoljaFrahm
Copy link
Contributor Author

Adjusted and rebased :)

@KoljaFrahm KoljaFrahm requested a review from agheata November 12, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auxiliaries of volumes are not exportet in gdml

3 participants