Address peer review comments

Signed-off-by: Michel Hidalgo <[email protected]>

Author: hidmic

rosidl_cli/rosidl_cli/cli.py

@@ -95,7 +95,7 @@ def main():
 
     # call the main method of the command
     try:
-        rc = args._command.main(parser=parser, args=args)
+        rc = args._command.main(args=args)
     except KeyboardInterrupt:
         rc = signal.SIGINT
     except (ValueError, RuntimeError) as e:

rosidl_cli/rosidl_cli/command/generate/__init__.py

@@ -51,7 +51,7 @@ def add_arguments(self, parser):
                   "If prefixed by another path followed by a colon ':', "
                   'path resolution is performed against such path.'))
 
-    def main(self, *, parser, args):
+    def main(self, *, args):
         extensions = []
 
         unspecific_generation = \

rosidl_cli/rosidl_cli/command/generate/helpers.py

@@ -19,9 +19,9 @@
 import tempfile
 
 
-def package_name_from_include_path(path):
+def package_name_from_interface_file_path(path):
     """
-    Derive ROS package name from a ROS interface dependency include path.
+    Derive ROS package name from a ROS interface definition file path.
 
     This function assumes ROS interface definition files follow the typical
     ``rosidl`` install space layout i.e. 'package_name/subfolder/interface.idl'.
@@ -37,7 +37,7 @@ def dependencies_from_include_paths(include_paths):
     prefixed by the name of package they belong to followed by a colon ':'.
     """
     return list({
-        f'{package_name_from_include_path(path)}:{path}'
+        f'{package_name_from_interface_file_path(path)}:{path}'
         for include_path in map(pathlib.Path, include_paths)
         for path in include_path.resolve().glob('**/*.idl')
     })

rosidl_cli/rosidl_cli/extensions.py

@@ -50,7 +50,7 @@ def load_extensions(group_name, *, strict=False, **kwargs):
         try:
             extensions.append(factory(name))
         except Exception as e:
-            msg = f"Failed to build extension '{name}': {e}"
+            msg = f"Failed to instantiate extension '{name}': {e}"
             if strict:
                 raise RuntimeError(msg)
             logger.warning(msg)