Fix hard download error on 404 etc

I've observed errors when some mirrors are not completely synced. The
library tries to download a file, but gets a 404 error. This means we
need to retry with another mirror, not crash out. This was crashing
because setting `err` in `clean_transcode()` was firing the assert at
the start of `truncate_transfer_file()`. Note this failure mode was most
common with 404's, but any transfer error could likely have turned
fatal, for invalid reasons.

We use `cleanup_transcode()` in two contexts.

1. Within `check_transfer_statuses()`. The first call here happens
   during a normal download after `check_finished_transfer_status()`.
   The cleanup checks for errors, and any here will be flagged as a
   `transfer_err` (not a general, err).
2. In 3 other places where an error has already occurred. We need to
   wait for the program to exit (and it should stop due to a SIGPIPE
   or short read from stdin), but we don't need to set an error because
   something already is handling one. It doesn't matter that the
   transcoder crashed because we're not going to use the output anyway,
   and we are likely to retry.

Author: malmond77

librepo/downloader.c

@@ -1545,8 +1545,12 @@ maybe_transcode(LrTarget *target, GError **err)
 }
 
 void
-cleanup_transcode(LrTarget *target, GError **err)
+cleanup_transcode(LrTarget *target, GError **transfer_err)
 {
+    /** transfer_err can be NULL if we're using this to clean up a failed
+     * transfer. In that circumstance g_set_error does nothing which is fine,
+     * we don't need to pile on a second failure reason.
+     */
     int wstatus, trc;
     if (!target->writef) {
         return;
@@ -1556,21 +1560,21 @@ cleanup_transcode(LrTarget *target, GError **err)
     }
     fclose(target->writef);
     if(waitpid(target->pid, &wstatus, 0) == -1) {
-        g_set_error(err, LR_DOWNLOADER_ERROR, LRE_TRANSCODE,
+        g_set_error(transfer_err, LR_DOWNLOADER_ERROR, LRE_TRANSCODE,
                     "transcode waitpid failed: %s", g_strerror(errno));
     } else if (WIFEXITED(wstatus)) {
         trc = WEXITSTATUS(wstatus);
         if (trc != 0) {
-            g_set_error(err, LR_DOWNLOADER_ERROR, LRE_TRANSCODE,
+            g_set_error(transfer_err, LR_DOWNLOADER_ERROR, LRE_TRANSCODE,
                         "transcode process non-zero exit code %d", trc);
         }
     } else if (WIFSIGNALED(wstatus)) {
-        g_set_error(err, LR_DOWNLOADER_ERROR, LRE_TRANSCODE,
+        g_set_error(transfer_err, LR_DOWNLOADER_ERROR, LRE_TRANSCODE,
                     "transcode process was terminated with a signal: %d",
                     WTERMSIG(wstatus));
     } else {
         /* don't think this can happen, but covering all bases */
-        g_set_error(err, LR_DOWNLOADER_ERROR, LRE_TRANSCODE,
+        g_set_error(transfer_err, LR_DOWNLOADER_ERROR, LRE_TRANSCODE,
                     "transcode unhandled circumstance in waitpid");
     }
     target->writef = NULL;
@@ -1837,7 +1841,7 @@ prepare_next_transfer(LrDownload *dd, gboolean *candidatefound, GError **err)
         curl_easy_cleanup(target->curl_handle);
         target->curl_handle = NULL;
     }
-    cleanup_transcode(target, err);
+    cleanup_transcode(target, NULL);
     if (target->f != NULL) {
         fclose(target->f);
         target->f = NULL;
@@ -2405,11 +2409,11 @@ check_transfer_statuses(LrDownload *dd, GError **err)
         if (!ret)  // Error
             return FALSE;
 
+        cleanup_transcode(target, &transfer_err);
+
         if (transfer_err)  // Transfer was unsuccessful
             goto transfer_error;
 
-        cleanup_transcode(target, err);
-
         //
         // Checksum checking
         //
@@ -2499,7 +2503,7 @@ check_transfer_statuses(LrDownload *dd, GError **err)
         target->curl_handle = NULL;
         g_free(target->headercb_interrupt_reason);
         target->headercb_interrupt_reason = NULL;
-        cleanup_transcode(target, err);
+        cleanup_transcode(target, NULL);
         fclose(target->f);
         target->f = NULL;
         if (target->curl_rqheaders) {
@@ -2903,7 +2907,7 @@ lr_download(GSList *targets,
             curl_multi_remove_handle(dd.multi_handle, target->curl_handle);
             curl_easy_cleanup(target->curl_handle);
             target->curl_handle = NULL;
-            cleanup_transcode(target, err);
+            cleanup_transcode(target, NULL);
             fclose(target->f);
             target->f = NULL;
             g_free(target->headercb_interrupt_reason);