chore: Replace unnecessary collections with iterators

- Use iterators directly instead of collecting into Vec in DisplayObjectSearchWindow::hovered_debug_rects
- Replace Vec collection with Either iterator in Avm2Button::construct_frame
- Pass array directly instead of creating Vec in do_reentry external interface test
- Avoid collecting JsValues before mapping in RuffleHandle::call_exposed_callback

Author: SuchAFuriousDeath

core/src/debug_ui.rs

@@ -194,11 +194,11 @@ impl DebugUi {
         }
 
         if let Some(window) = &self.display_object_search {
-            for (color, object) in window.hovered_debug_rects() {
+            for (object, color) in window.hovered_debug_rects() {
                 let object = object.fetch(dynamic_root_set);
                 let bounds = world_matrix * object.debug_rect_bounds();
 
-                draw_debug_rect(context, color, bounds, 5.0);
+                draw_debug_rect(context, *color, bounds, 5.0);
             }
         }
 

core/src/debug_ui/display_object/search.rs

@@ -8,6 +8,7 @@ use crate::display_object::{
 use egui::collapsing_header::CollapsingState;
 use egui::color_picker::show_color;
 use egui::{Rgba, Ui, Vec2, Window};
+use either::Either;
 use fnv::FnvHashMap;
 use swf::{Point, Twips};
 
@@ -29,14 +30,11 @@ pub struct DisplayObjectSearchWindow {
 }
 
 impl DisplayObjectSearchWindow {
-    pub fn hovered_debug_rects(&self) -> Vec<(swf::Color, DisplayObjectHandle)> {
+    pub fn hovered_debug_rects(&self) -> impl Iterator<Item = (&DisplayObjectHandle, &swf::Color)> {
         if let Some(hovered_debug_rect) = &self.hovered_debug_rect {
-            vec![(swf::Color::RED, hovered_debug_rect.clone())]
+            Either::Left(core::iter::once((hovered_debug_rect, &swf::Color::RED)))
         } else {
-            self.unique_results
-                .iter()
-                .map(|(k, v)| (*v, k.clone()))
-                .collect()
+            Either::Right(self.unique_results.iter())
         }
     }
 

core/src/display_object/avm2_button.rs

@@ -22,6 +22,7 @@ use crate::tag_utils::{SwfMovie, SwfSlice};
 use crate::utils::HasPrefixField;
 use crate::vminterface::Instantiator;
 use core::fmt;
+use either::Either;
 use gc_arena::barrier::unlock;
 use gc_arena::lock::Lock;
 use gc_arena::{Collect, Gc, Mutation};
@@ -478,16 +479,14 @@ impl<'gc> TDisplayObject<'gc> for Avm2Button<'gc> {
                 self.create_state(context, swf::ButtonState::HIT_TEST);
 
             let has_movie_clip_state = {
-                let objs: Vec<_> = if up_should_fire {
-                    up_state
-                        .as_container()
-                        .unwrap()
-                        .iter_render_list()
-                        .collect()
+                let objs = if up_should_fire {
+                    Either::Left(up_state.as_container().unwrap().iter_render_list())
                 } else {
-                    vec![up_state]
+                    Either::Right(core::iter::once(up_state))
                 };
-                objs.iter().any(|display| display.as_movie_clip().is_some())
+
+                objs.into_iter()
+                    .any(|display| display.as_movie_clip().is_some())
             };
 
             let write = Gc::write(context.gc(), self.0);

tests/tests/external_interface/mod.rs

@@ -33,7 +33,7 @@ fn do_reentry(context: &mut UpdateContext<'_>, _args: &[ExternalValue]) -> Exter
         callback.call(
             context,
             "callWith",
-            vec!["trace".into(), "successful reentry!".into()],
+            ["trace".into(), "successful reentry!".into()],
         )
     } else {
         ExternalValue::Null

web/src/lib.rs

@@ -1,5 +1,4 @@
 #![deny(clippy::unwrap_used)]
-#![allow(clippy::empty_docs)] //False positive in rustc 1.78 beta
 
 //! Ruffle web frontend.
 mod audio;
@@ -435,7 +434,7 @@ impl RuffleHandle {
         #[expect(clippy::boxed_local)] // for js_bind
         args: Box<[JsValue]>,
     ) -> JsValue {
-        let args: Vec<_> = args.iter().map(js_to_external_value).collect();
+        let args = args.iter().map(js_to_external_value);
 
         // Re-entrant callbacks need to return through the hole that was punched through for them
         // We record the context of external functions, and then if we get an internal callback