Skip to content

Trimming of suggestions needs to be syntax aware which is out of scope #344

@epage

Description

@epage

Looking at #343, we can see that the trimming logic should really care about atomic units of syntax. While we can pile more hacks on top of our existing ones, we'll never reach syntax awareness for full correctness.

Pushing this to the caller would allow the caller to either be syntax aware or specialize the hacks to their needs. In fact, having the current heuristics could run counter to someone doing that today.

This also better fits with the literalism that we embraced with the lastest API design (see also #309)

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: enhancementM-breaking-changeMeta: Implementing or merging this will introduce a breaking change

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions