-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
C-bugCategory: bugCategory: bugE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.breakage-candidate
Milestone
Description
On Linux, clone takes a callback function pointer. The function pointer type is not marked unsafe
, but there is basically no way to implement this callback with a safe function since it takes its context parameter by pointer.
It seems to me that unsafe
should be added to the function pointer type, e.g.:
pub fn clone( cb: unsafe extern "C" fn(*mut ::c_void) -> ::c_int, child_stack: *mut ::c_void, flags: ::c_int, arg: *mut ::c_void, ... ) -> ::c_int;
I'm not certain, but I don't think this would be a breaking change.
purplesyringa
Metadata
Metadata
Assignees
Labels
C-bugCategory: bugCategory: bugE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.breakage-candidate