Skip to content

Commit f25db55

Browse files
authored
Merge pull request #21190 from Veykril/push-puqrkvrtqxnz
fix: Fix proc-macro-srv passing invalid extra none group to proc-macros
2 parents d690155 + 5ca77bd commit f25db55

File tree

2 files changed

+16
-6
lines changed
  • crates
    • proc-macro-api/src/legacy_protocol/msg
    • proc-macro-srv/src/tests

2 files changed

+16
-6
lines changed

crates/proc-macro-api/src/legacy_protocol/msg/flat.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -962,8 +962,6 @@ impl<T: SpanTransformer> Reader<'_, T> {
962962
};
963963
res[i] = Some(g);
964964
}
965-
proc_macro_srv::TokenStream::new(vec![proc_macro_srv::TokenTree::Group(
966-
res[0].take().unwrap(),
967-
)])
965+
res[0].take().unwrap().stream.unwrap_or_default()
968966
}
969967
}

crates/proc-macro-srv/src/tests/mod.rs

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -297,26 +297,38 @@ fn test_fn_like_macro_noop() {
297297
fn test_fn_like_macro_clone_ident_subtree() {
298298
assert_expand(
299299
"fn_like_clone_tokens",
300-
r#"ident, []"#,
300+
r#"ident, [ident2, ident3]"#,
301301
expect![[r#"
302302
IDENT 1 ident
303303
PUNCT 1 , [alone]
304304
GROUP [] 1 1 1
305+
IDENT 1 ident2
306+
PUNCT 1 , [alone]
307+
IDENT 1 ident3
305308
306309
307310
IDENT 1 ident
308311
PUNCT 1 , [alone]
309312
GROUP [] 1 1 1
313+
IDENT 1 ident2
314+
PUNCT 1 , [alone]
315+
IDENT 1 ident3
310316
"#]],
311317
expect![[r#"
312318
IDENT 42:Root[0000, 0]@0..5#ROOT2024 ident
313319
PUNCT 42:Root[0000, 0]@5..6#ROOT2024 , [alone]
314-
GROUP [] 42:Root[0000, 0]@7..8#ROOT2024 42:Root[0000, 0]@8..9#ROOT2024 42:Root[0000, 0]@7..9#ROOT2024
320+
GROUP [] 42:Root[0000, 0]@7..8#ROOT2024 42:Root[0000, 0]@22..23#ROOT2024 42:Root[0000, 0]@7..23#ROOT2024
321+
IDENT 42:Root[0000, 0]@8..14#ROOT2024 ident2
322+
PUNCT 42:Root[0000, 0]@14..15#ROOT2024 , [alone]
323+
IDENT 42:Root[0000, 0]@16..22#ROOT2024 ident3
315324
316325
317326
IDENT 42:Root[0000, 0]@0..5#ROOT2024 ident
318327
PUNCT 42:Root[0000, 0]@5..6#ROOT2024 , [alone]
319-
GROUP [] 42:Root[0000, 0]@7..9#ROOT2024 42:Root[0000, 0]@7..9#ROOT2024 42:Root[0000, 0]@7..9#ROOT2024
328+
GROUP [] 42:Root[0000, 0]@7..23#ROOT2024 42:Root[0000, 0]@7..23#ROOT2024 42:Root[0000, 0]@7..23#ROOT2024
329+
IDENT 42:Root[0000, 0]@8..14#ROOT2024 ident2
330+
PUNCT 42:Root[0000, 0]@14..15#ROOT2024 , [alone]
331+
IDENT 42:Root[0000, 0]@16..22#ROOT2024 ident3
320332
"#]],
321333
);
322334
}

0 commit comments

Comments
 (0)