Skip to content

Commit 22319c8

Browse files
committed
Fix markdown lints
1 parent 01bb480 commit 22319c8

File tree

1 file changed

+17
-31
lines changed

1 file changed

+17
-31
lines changed

src/2025h2/relink-dont-rebuild.md

Lines changed: 17 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
| Metadata | |
55
| -------- | --- |
66
| Point of contact | @yaahc |
7-
| Teams | @compiler, @cargo |
8-
| Task Owner(s) | @yaahc, @dropbear32 |
7+
| Teams | <!-- TEAMS WITH ASKS --> |
8+
| Task owners | <!-- TASK OWNERS --> |
99
| Status | Proposed |
10-
| Tracking Issue | TBD |
11-
| Zulip Channel | TBD |
10+
| Tracking issue | |
11+
| Zulip channel | |
1212

1313
## Summary
1414

15-
Work towards avoiding rebuilds of a crate's dependents for changes that don't affect the crate's
15+
Work towards avoiding rebuilds of a crate's dependents for changes that don't affect the crate's
1616
public interface.
1717

1818
<!--Our end goal is to have some flags available on nightly that enable avoiding unnecessary rebuilds in certain cases. -->
@@ -36,9 +36,9 @@ identical one all cause rebuilds of reverse dependencies of that crate.
3636
This clashes with users' intuition for what needs to be rebuilt when certain changes are made
3737
and makes iterating more painful.
3838

39-
As a point of reference, in C and C++ – where there is a strict separation between interface
40-
and implementation in the form of header files – equivalent changes would only cause a
41-
rebuild of the translation unit whose source has been modified. For other units, existing
39+
As a point of reference, in C and C++ – where there is a strict separation between interface
40+
and implementation in the form of header files – equivalent changes would only cause a
41+
rebuild of the translation unit whose source has been modified. For other units, existing
4242
compiler outputs would be reused (and re-linked into the final binary).
4343

4444
Our goal is to work towards making `cargo` and `rustc` smarter about when they do or don't need to
@@ -79,13 +79,13 @@ flowchart TB
7979
grep
8080
ignore
8181
ripgrep
82-
82+
8383
globset --> ignore --> ripgrep
84-
84+
8585
globset --> grep-cli --> grep --> ripgrep
8686
```
8787

88-
Consider a change that does not alter the interface of the `globset` crate (for example,
88+
Consider a change that does not alter the interface of the `globset` crate (for example,
8989
modifying a private item or changing a comment within `globset`'s source code).
9090

9191
Here is the output of `cargo build --timings` for an incremental build of `ripgrep` where only
@@ -168,7 +168,7 @@ flowchart TB
168168
```
169169

170170
[^caveat_pipelining]:
171-
We have taken some liberties in the above graph w.r.t. pipelining.
171+
We have taken some liberties in the above graph w.r.t. pipelining.
172172
Today, `cargo` preforms a single `rustc` invocation to produce the `rlib` and `rmeta`
173173
for each crate – `rmeta` is modeled as an "early out".
174174
Additionally, producing `ripgrep.rlib` and linking (the `rg (bin)` node) happens as part
@@ -300,9 +300,9 @@ in `rustc_TBD`'s interface).
300300
301301
*This text is NORMATIVE, in the sense that teams should review this and make sure they are aligned. If not, then the shiny future should be moved to frequently asked questions with a title like "what might we do next".*-->
302302

303-
Only changes to a crate that affect the public interface of the crate should cause downstream
303+
Only changes to a crate that affect the public interface of the crate should cause downstream
304304
crates to rebuild.
305-
305+
306306
<!--
307307
## Design axioms
308308
@@ -320,15 +320,16 @@ crates to rebuild.
320320
321321
*This section defines the specific work items that are planned and who is expected to do them. It should also include what will be needed from Rust teams. The table below shows some common sets of asks and work, but feel free to adjust it as needed. Every row in the table should either correspond to something done by a contributor or something asked of a team. For items done by a contributor, list the contributor, or ![Heap wanted][] if you don't yet know who will do it. For things asked of teams, list ![Team][] and the name of the team. The things typically asked of teams are defined in the [Definitions](#definitions) section below.* -->
322322

323-
| Subgoal | Owner(s) or team(s) | Notes |
323+
| Task | Owner(s) or team(s) | Notes |
324324
| ----------------------------- | ----------------------- | ----- |
325325
| Design meeting | ![Team][] [compiler] | |
326326
| Discussion and moral support | ![Team][] [compiler] ![Team][] [cargo] | |
327327
| Nightly experiment for RDR | | |
328328
| ↳ Author MCP | @osiewicz | [already accepted](https://github.com/rust-lang/compiler-team/issues/790) |
329329
| ↳ Rustc Implementation | | [WIP](https://github.com/osiewicz/rust/tree/api-fingerprinting) |
330330
| ↳ Cargo Implementation | | [WIP](https://github.com/osiewicz/cargo/tree/api-fingerprinting) |
331-
| ↳ Standard reviews | ![Team][] [compiler] ![Team][] [cargo] | |
331+
| Improve DefId stability | @dropbear32 | |
332+
| Standard reviews | ![Team][] [compiler] [cargo] | |
332333

333334
### Definitions
334335

@@ -366,18 +367,3 @@ todo: why not devote resources towards just speeding up `rustc` incrmental?
366367
367368
idk that we want to draw attention to this or that it's worth calling out...
368369
-->
369-
370-
###
371-
372-
<!--
373-
374-
### What do I do with this space?
375-
376-
This is a good place to elaborate on your reasoning above -- for example, why did you put the
377-
design axioms in the order that you did? It's also a good place to put the answers to any
378-
questions that come up during discussion. The expectation is that this FAQ section will grow
379-
as the goal is discussed and eventually should contain a complete summary of the points
380-
raised along the way.
381-
382-
-->
383-

0 commit comments

Comments
 (0)