Add goal to run more GCC tests in rust CI #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Jun 30, 2025
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
I would clarify on which targets this should be running (probably only x64 Linux for now?), and add a work item for extending documentation, so that contributors know what to do in the case of failure.
GuillaumeGomez
force-pushed
the
gcc-tests
branch
from
33b119f to
29c64c3
Compare
Member
Author
|
Very good points, updated. |
lqd
reviewed
Jul 18, 2025
src/2025h2/gcc-backend-tests.md
Outdated
| | Task | Owner(s) or team(s) | Notes | | ||
| |-------------------------------|---------------------|-------| | ||
| | Adding new ui annotations | @GuillaumeGomez | | | ||
| | Running more GCC backend tests | @GuillaumeGomez with the help of t-infra and t-compiler for reviews and ensuring is done as they want | | |
Member
There was a problem hiding this comment.
Here as well, asks are codified for tooling purposes.
Suggested change
| | Running more GCC backend tests | @GuillaumeGomez with the help of t-infra and t-compiler for reviews and ensuring is done as they want | | | |
| | Running more GCC backend tests | @GuillaumeGomez | | | |
| | Standard reviews | ![Team][] [infra], [compiler] | with the help of t-infra and t-compiler for reviews and ensuring is done as they want | |
GuillaumeGomez
force-pushed
the
gcc-tests
branch
from
29c64c3 to
d76d6db
Compare
Member
Author
|
Thanks! Applied suggestion. :) |
nikomatsakis
approved these changes
Jul 21, 2025
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
This is exciting but also a significant step (testing a new backend).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc rust-lang/compiler-team#891
cc @antoyo (maintainer of the GCC backend)
cc @Kobzol (for bootstrap/infra team)
cc @rust-lang/compiler (directly impacted by this goal)
Rendered