-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
A-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)Area: test infrastructure (may span bootstrap/compiletest/more)A-test-infra-minicoreArea: `minicore` test auxiliary and `//@ add-core-stubs`Area: `minicore` test auxiliary and `//@ add-core-stubs`A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Currently, there's no safeguard to guard against minicore
signatures and type definitions drifting/diverging from that of the real core
, which is very much not ideal. We should figure out a way to check if the signatures (and type definitions, where applicable) match between minicore
and real core
.
One related issue that may help with this is to use host core
when available but that in itself is insufficient (and can cause complications where something only fails on targets where host core
isn't available).
Metadata
Metadata
Assignees
Labels
A-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)Area: test infrastructure (may span bootstrap/compiletest/more)A-test-infra-minicoreArea: `minicore` test auxiliary and `//@ add-core-stubs`Area: `minicore` test auxiliary and `//@ add-core-stubs`A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.