Skip to content

disable-minification is not forwarded to compiletest #142737

Open
@lolbinarycat

Description

@lolbinarycat

Summary

For documention built by compiletest directly, the build.disable-minification setting is ignored.

Command used

./x test tests/rustdoc-js

Expected behaviour

If disable-minification is set, this applies to all test suites, not just some of them.

Actual behaviour

The rustdoc-js test suite always has minification enabled.

Bootstrap configuration (bootstrap.toml)

profile = "tools"  # Includes one of the default files in src/bootstrap/defaults
change-id = 138986

rust.debuginfo-level = 1
rust.jemalloc = false
rust.download-rustc = false
rust.deny-warnings = false
build.docs-minification = false

Operating system

Arch Linux

HEAD

3bc767e

Additional context

This is an issue if an error occurs when running that test suite, as you won't get a meaningful line number.

The invocation site where --disable-minification should be passed but isn't is at compiletest::runtest::document.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions