Impls and impl items inherit lint levels of the corresponding traits and trait items #144113
+56
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
| } | ||
|
|
||
| impl Foo for u32 { | ||
| const FOO: u32 = bar(0); |
There was a problem hiding this comment.
This test should probably also demonstrate the analogous behavior for fn items. And do we lint for unused structs in associated items?
mu001999
force-pushed
the
dead-code/allow-trait
branch
from
7eba1f1 to
7a9e2e2
Compare
@compiler-errors yes, and I think this makes sense. We would have only one trait definition but many impls, letting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rust-lang/rust/blob/master/compiler/rustc_passes/src/dead.rs#L360-L361 won't insert assoc items into the live set, so that impl items cannot be marked live.
This PR lets impls and impl items can inherit lint levels of the corresponding traits and trait items.
Fixes #144060
r? @petrochenkov