fix: sharpen the IntrinsicType recognition function from_values

Author: madhav-madhusoodanan

crates/intrinsic-test/src/loongarch/types.rs

@@ -1,9 +1,6 @@
 use super::intrinsic::LoongArchIntrinsicType;
 use crate::common::cli::Language;
-<<<<<<< HEAD
-=======
 use crate::common::intrinsic_helpers::Sign;
->>>>>>> b094de07 (chenj)
 use crate::common::intrinsic_helpers::{IntrinsicType, IntrinsicTypeDefinition, TypeKind};
 
 impl IntrinsicTypeDefinition for LoongArchIntrinsicType {
@@ -32,42 +29,37 @@ impl LoongArchIntrinsicType {
     /// Accepts X, Y and Z.
     /// Returns a `LoongArchType`
     pub fn from_values(asm_fmt: &String, data_type: &String) -> Result<Self, String> {
-        let bit_len = match data_type.as_str() {
-            "A16QI" => Some(8),
-            "AM16QI" => Some(8),
-            "V16QI" => Some(8),
-            "V32QI" => Some(8),
-            "A32QI" => Some(8),
-            "AM32QI" => Some(8),
-            "V8HI" => Some(16),
-            "V16HI" => Some(16),
-            "V4SI" => Some(32),
-            "V8SI" => Some(32),
-            "V2DI" => Some(64),
-            "V4DI" => Some(64),
-            "UV16QI" => Some(8),
-            "UV32QI" => Some(8),
-            "UV8HI" => Some(16),
-            "UV16HI" => Some(16),
-            "UV4SI" => Some(32),
-            "UV8SI" => Some(32),
-            "UV2DI" => Some(64),
-            "UV4DI" => Some(64),
-            "V4SF" => Some(32),
-            "V8SF" => Some(32),
-            "V2DF" => Some(64),
-            "V4DF" => Some(64),
-            "SI" | "DI" | "USI" | "UDI" | "UQI" | "QI" | "CVPOINTER" | "HI" => None,
+        let (bit_len, vec_len, type_kind) = match data_type.as_str() {
+            "A16QI" => (Some(8), Some(16), TypeKind::Int(Sign::Signed)),
+            "AM16QI" => (Some(8), Some(16), TypeKind::Int(Sign::Signed)),
+            "V16QI" => (Some(8), Some(16), TypeKind::Int(Sign::Signed)),
+            "V32QI" => (Some(8), Some(32), TypeKind::Int(Sign::Signed)),
+            "A32QI" => (Some(8), Some(32), TypeKind::Int(Sign::Signed)),
+            "AM32QI" => (Some(8), Some(32), TypeKind::Int(Sign::Signed)),
+            "V8HI" => (Some(16), Some(8), TypeKind::Int(Sign::Signed)),
+            "V16HI" => (Some(16), Some(16), TypeKind::Int(Sign::Signed)),
+            "V4SI" => (Some(32), Some(4), TypeKind::Int(Sign::Signed)),
+            "V8SI" => (Some(32), Some(8), TypeKind::Int(Sign::Signed)),
+            "V2DI" => (Some(64), Some(2), TypeKind::Int(Sign::Signed)),
+            "V4DI" => (Some(64), Some(4), TypeKind::Int(Sign::Signed)),
+            "UV16QI" => (Some(8), Some(16), TypeKind::Int(Sign::Unsigned)),
+            "UV32QI" => (Some(8), Some(32), TypeKind::Int(Sign::Unsigned)),
+            "UV8HI" => (Some(16), Some(8), TypeKind::Int(Sign::Unsigned)),
+            "UV16HI" => (Some(16), Some(16), TypeKind::Int(Sign::Unsigned)),
+            "UV4SI" => (Some(32), Some(4), TypeKind::Int(Sign::Unsigned)),
+            "UV8SI" => (Some(32), Some(8), TypeKind::Int(Sign::Unsigned)),
+            "UV2DI" => (Some(64), Some(2), TypeKind::Int(Sign::Unsigned)),
+            "UV4DI" => (Some(64), Some(4), TypeKind::Int(Sign::Unsigned)),
+            "V4SF" => (Some(32), Some(4), TypeKind::Float),
+            "V8SF" => (Some(32), Some(8), TypeKind::Float),
+            "V2DF" => (Some(64), Some(2), TypeKind::Float),
+            "V4DF" => (Some(64), Some(4), TypeKind::Float),
+            "SI" | "DI" | "USI" | "UDI" | "UQI" | "QI" | "CVPOINTER" | "HI" => {
+                (None, None, TypeKind::Int(Sign::Signed))
+            }
             _ => panic!("unknown type {data_type} with ASM {asm_fmt}"),
         };
 
-        let vec_len = match data_type.as_str() {
-            "SI" | "DI" | "USI" | "UDI" | "UQI" | "QI" | "HI" | => None,
-            "V32QI" | "V16HI" | "V8SI" | "V4DI" | "UV32QI" | "UV16HI" | "UV8SI" | "UV4DI"
-            | "V8SF" | "V4DF" => Some(4),
-            _ => Some(2),
-        };
-
         Ok(LoongArchIntrinsicType {
             data: IntrinsicType {
                 constant: false,
@@ -76,8 +68,8 @@ impl LoongArchIntrinsicType {
                 kind: TypeKind::Mask,
                 bit_len,
                 vec_len,
-                simd_len: None
-            }
+                simd_len: None,
+            },
         })
     }
 }