Provide a non-owning constructor for Issuer

p-avital · cpu · commit c2283bb5e146 · 2025-07-04T13:03:13.000Z
diff --git a/rcgen/src/lib.rs b/rcgen/src/lib.rs
@@ -209,7 +209,11 @@ impl<'a, S: SigningKey> Issuer<'a, S> {
 		}
 	}
 
-	fn from_params(params: &'a CertificateParams, signing_key: &'a S) -> Self {
+	/// Create a new issuer from the given parameters and signing key references.
+	///
+	/// Use [`Issuer::new`] instead if you want to obtain an [`Issuer`] that owns
+	/// its parameters.
+	pub fn from_params(params: &'a CertificateParams, signing_key: &'a S) -> Self {
 		Self {
 			distinguished_name: Cow::Borrowed(&params.distinguished_name),
 			key_identifier_method: Cow::Borrowed(&params.key_identifier_method),

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,11 @@ impl<'a, S: SigningKey> Issuer<'a, S> {`
`209`	`209`	`}`
`210`	`210`	`}`
`211`	`211`
`212`		`- fn from_params(params: &'a CertificateParams, signing_key: &'a S) -> Self {`
	`212`	`+ /// Create a new issuer from the given parameters and signing key references.`
	`213`	`+ ///`
	`214`	+ /// Use [`Issuer::new`] instead if you want to obtain an [`Issuer`] that owns
	`215`	`+ /// its parameters.`
	`216`	`+ pub fn from_params(params: &'a CertificateParams, signing_key: &'a S) -> Self {`
`213`	`217`	`Self {`
`214`	`218`	`distinguished_name: Cow::Borrowed(&params.distinguished_name),`
`215`	`219`	`key_identifier_method: Cow::Borrowed(&params.key_identifier_method),`