Skip to content

Commit 60af99c

Browse files
committed
Refactor ObservableAnalogInput to use int type for consistency
1 parent 3cfb260 commit 60af99c

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

src/Observables/ObservableAnalogInput.h

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,43 +10,38 @@ Unless required by applicable law or agreed to in writing, software distributed
1010
#ifndef _REACTIVEOBSERVABLEANALOGINPUT_h
1111
#define _REACTIVEOBSERVABLEANALOGINPUT_h
1212

13-
template <typename T>
14-
class ObservableAnalogInput : public Observable<T>
13+
class ObservableAnalogInput : public Observable<int>
1514
{
1615
public:
1716
ObservableAnalogInput(uint8_t pin, uint8_t pinMode = INPUT);
18-
void Subscribe(IObserver<T> &observer) override;
19-
void UnSubscribe(IObserver<T> &observer) override;
17+
void Subscribe(IObserver<int> &observer) override;
18+
void UnSubscribe(IObserver<int> &observer) override;
2019

2120
void Next();
2221

2322
private:
2423
uint8_t _pin;
2524

26-
ObserverList<T> _childObservers;
25+
ObserverList<int> _childObservers;
2726
};
2827

29-
template <typename T>
30-
ObservableAnalogInput<T>::ObservableAnalogInput(uint8_t pin, uint8_t mode)
28+
ObservableAnalogInput<int>::ObservableAnalogInput(uint8_t pin, uint8_t mode)
3129
{
3230
_pin = pin;
3331
pinMode(pin, mode);
3432
}
3533

36-
template <typename T>
37-
void ObservableAnalogInput<T>::Subscribe(IObserver<T> &observer)
34+
void ObservableAnalogInput<int>::Subscribe(IObserver<T> &observer)
3835
{
3936
this->_childObservers.Add(&observer);
4037
}
4138

42-
template <typename T>
43-
void ObservableAnalogInput<T>::UnSubscribe(IObserver<T> &observer)
39+
void ObservableAnalogInput<int>::UnSubscribe(IObserver<T> &observer)
4440
{
4541
this->_childObservers.Remove(&observer);
4642
}
4743

48-
template <typename T>
49-
void ObservableAnalogInput<T>::Next()
44+
void ObservableAnalogInput<int>::Next()
5045
{
5146
this->_childObservers.OnNext(analogRead(_pin));
5247
}

0 commit comments

Comments
 (0)