src/sage/geometry/cone.py: optimize cone containment check

Rewrite the conditionals inside the main loop of _contains() to avoid
one equality test. Currently, in the worst case (where we do not
return False and proceed to the next constraint), we test,

  * c.is_equality()
  * pr != 0
  * pr < 0
  * need_strict
  * pr == 0 (redundant!)

After rewriting, we test

  * pr > 0
  * pr < 0
  * need_strict
  * c.is_equality()

For this to matter, you need to check an absurd number of conditions,
but %timeit does show a small improvement after many repeated runs.

Author: orlitzky

src/sage/geometry/cone.py

@@ -1686,11 +1686,14 @@ def _contains(self, point, region='whole cone'):
         M = self.dual_lattice()
         for c in self._PPL_cone().minimized_constraints():
             pr = M(c.coefficients()) * point
-            if c.is_equality():
-                if pr != 0:
-                    return False
-            elif pr < 0 or need_strict and pr == 0:
+            if pr < 0:
                 return False
+            elif pr > 0:
+                if c.is_equality():
+                    return False
+            else:
+                if need_strict and not c.is_equality():
+                    return False
         return True
 
     def interior_contains(self, *args):