Avoid warning from gcc8 about memcpy overflow

jkbonfield · daviesrob · commit 0eac47dd7589 · 2019-05-31T15:08:28.000+01:00
diff --git a/htslib/kstring.h b/htslib/kstring.h
@@ -156,6 +156,9 @@ static inline char *ks_release(kstring_t *s)
 
 static inline int kputsn(const char *p, size_t l, kstring_t *s)
 {
+	if (l > SIZE_MAX-2)
+		return EOF;
+
 	size_t new_sz = s->l + l + 2;
 	if (new_sz < s->l || ks_resize(s, new_sz) < 0)
 		return EOF;

Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,9 @@ static inline char ks_release(kstring_t s)`
`156`	`156`
`157`	`157`	`static inline int kputsn(const char p, size_t l, kstring_t s)`
`158`	`158`	`{`
	`159`	`+ if (l > SIZE_MAX-2)`
	`160`	`+ return EOF;`
	`161`	`+`
`159`	`162`	`size_t new_sz = s->l + l + 2;`
`160`	`163`	`if (new_sz < s->l \|\| ks_resize(s, new_sz) < 0)`
`161`	`164`	`return EOF;`