Skip to content

resource lb backend. Add missing configs from health checks types #1976

@Monitob

Description

@Monitob

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please add the missing configs on the lb_backend:

  • LdapConfig
  • MysqlConfig
  • PgsqlConfig
  • RedisConfig

Maybe a dedicated resource is needed.

New or Affected Resource(s)

  • scaleway_lb_backend

Potential Terraform Configuration

Today the provider enables a new attribute by health check types. This becomes problematic when we try to set it all dynamically, like in the example below. I propose to create only one block health_check with all the attributes instead of three differents.

 dynamic "health_check_tcp" {
    for_each = [
    ...
    ]
    content {}
  }

  dynamic "health_check_http" {
    for_each = [
      ...
    ]
    content {
      uri         = try(health_check_http.value["uri"], null)
      code        = try(health_check_http.value["code"], null)
      method      = try(health_check_http.value["method"], null)
      host_header = try(health_check_http.value["host_header"], null)
    }
  }

  dynamic "health_check_https" {
    for_each = [
      ....
    ]
    content {
      uri         = try(health_check_https.value["uri"], null)
      code        = try(health_check_https.value["code"], null)
      method      = try(health_check_https.value["method"], null)
      host_header = try(health_check_https.value["host_header"], null)
      sni         = try(health_check_https.value["sni"], null)
    }
  }

proposition:

resource scaleway_lb_backend bkd01 {
				....

health_check {
  uri = "http://test.com/health"
  method = "POST"
  code = 404
  host_header = "test.com"
  sni = "sni.test.com"
 }
}

References

  • #0000

Metadata

Metadata

Assignees

Labels

enhancementload-balancerLoad-balancer issues, bugs and feature requestspriority:mediumImprovements that are not the main priority

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions