Skip to content

Commit 7eec7ce

Browse files
committed
GHA Apple - Fix typo and try to preserve symlinks
1 parent 12dd0a4 commit 7eec7ce

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/apple.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ jobs:
148148
- name: Zip LSL Framework
149149
run: |
150150
cd install/Frameworks
151-
zip -r lsl.framework.zip lsl.framework
151+
zip -ry lsl.framework.zip lsl.framework
152152
cd ../..
153153
154154
- name: Upload macOS Package and Framework
@@ -159,16 +159,18 @@ jobs:
159159
path: |
160160
package/*.pkg
161161
install/Frameworks/lsl.framework.zip
162+
# Note: the artifact will preserves the folder structure up to the common root, in this case all.
162163

163164
- name: Upload iOS Framework
164165
if: matrix.config.name == 'iOS'
165166
uses: actions/upload-artifact@v4
166167
with:
167168
name: build-iOS
168169
path: install/Frameworks/lsl.framework.zip
170+
# Note: the artifact drops the folder structure and only keeps the zip.
169171

170172
xcframework_and_deploy:
171-
name: XSFramework and Deploy
173+
name: XCFramework and Deploy
172174
needs: build
173175
runs-on: macOS-latest
174176
steps:
@@ -185,7 +187,6 @@ jobs:
185187
- name: Unzip macOS Framework
186188
run: |
187189
unzip build-macOS-latest/install/Frameworks/lsl.framework.zip -d build-macOS-latest/Frameworks
188-
# unpackage build-macOS-latest/package/liblsl-$LSL_VERSION-Darwin-universal.pkg
189190
190191
- name: Unzip iOS Framework
191192
run: |

0 commit comments

Comments
 (0)