Honor SSLKEYLOGFILE by default. #1092
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokio_rustls already enables rustls's logging feature therefore we can enable this so that debugging warp TLS servers is simple and easy out of the box. Security concerns of enabling by default are limited since if you can alter environnement you can probably also read warp's server memory and achieve the same thing.
seanmonstar
requested changes
Feb 8, 2024
Owner
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
I dunno about being enabled by default, but a builder option to enable it could be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokio_rustls already enables rustls's logging feature therefore we can enable this so that debugging warp TLS servers is simple and easy out of the box. Security concerns of enabling by default are limited since if you can alter environnement you can probably also read warp's server memory and achieve the same thing.