Skip to content

Commit b9d130a

Browse files
staabmsebastianbergmann
authored andcommitted
Remove getElementsByTagNameNS() for cases which can never find a element
1 parent a5d3a88 commit b9d130a

File tree

2 files changed

+12
-26
lines changed

2 files changed

+12
-26
lines changed

src/Report/Xml/Project.php

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -75,19 +75,12 @@ public function buildInformation(
7575

7676
public function tests(): Tests
7777
{
78-
$testsNode = $this->contextNode()->getElementsByTagNameNS(
79-
Facade::XML_NAMESPACE,
80-
'tests',
81-
)->item(0);
82-
83-
if ($testsNode === null) {
84-
$testsNode = $this->contextNode()->appendChild(
85-
$this->dom()->createElementNS(
86-
Facade::XML_NAMESPACE,
87-
'tests',
88-
),
89-
);
90-
}
78+
$testsNode = $this->contextNode()->appendChild(
79+
$this->dom()->createElementNS(
80+
Facade::XML_NAMESPACE,
81+
'tests',
82+
),
83+
);
9184

9285
assert($testsNode instanceof DOMElement);
9386

src/Report/Xml/Report.php

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -119,19 +119,12 @@ public function traitObject(
119119

120120
public function source(): Source
121121
{
122-
$source = $this->contextNode()->getElementsByTagNameNS(
123-
Facade::XML_NAMESPACE,
124-
'source',
125-
)->item(0);
126-
127-
if ($source === null) {
128-
$source = $this->contextNode()->appendChild(
129-
$this->dom()->createElementNS(
130-
Facade::XML_NAMESPACE,
131-
'source',
132-
),
133-
);
134-
}
122+
$source = $this->contextNode()->appendChild(
123+
$this->dom()->createElementNS(
124+
Facade::XML_NAMESPACE,
125+
'source',
126+
),
127+
);
135128

136129
assert($source instanceof DOMElement);
137130

0 commit comments

Comments
 (0)