fix resumeabrupt handling

Author: lahma

Jint/Engine.cs

@@ -411,7 +411,7 @@ internal JsValue GetValue(object value, bool returnReferenceToPool)
                 return jsValue;
             }
 
-            if (!(value is Reference reference))
+            if (value is not Reference reference)
             {
                 return ((Completion) value).Value;
             }

Jint/Native/Generator/GeneratorInstance.cs

@@ -1,5 +1,4 @@
-using System.Diagnostics;
-using Jint.Native.Iterator;
+using Jint.Native.Iterator;
 using Jint.Native.Object;
 using Jint.Runtime;
 using Jint.Runtime.Environments;
@@ -73,7 +72,27 @@ public JsValue GeneratorResume(JsValue value, JsValue generatorBrand)
             _generatorState = GeneratorState.Executing;
             _engine.EnterExecutionContext(genContext);
 
-            return EvaluateGenerator();
+            var result = _generatorBody.Execute();
+
+            JsValue resultValue = null;
+            if (result.Type == CompletionType.Normal)
+            {
+                _generatorState = GeneratorState.Completed;
+                resultValue = IteratorInstance.ValueIteratorPosition.Done;
+            }
+            else if (result.Type == CompletionType.Return)
+            {
+                resultValue = result.Value;
+            }
+
+            if (result.Type == CompletionType.Throw)
+            {
+                // TODO handle
+                _generatorState = GeneratorState.Completed;
+                throw new JavaScriptException(result.Value);
+            }
+
+            return resultValue;
         }
 
         /// <summary>
@@ -105,12 +124,17 @@ public JsValue GeneratorResumeAbrupt(in Completion abruptCompletion, JsValue gen
 
             _generatorState = GeneratorState.Executing;
 
-            _engine.EnterExecutionContext(genContext);
+            //_engine.EnterExecutionContext(genContext);
 
-            // Resume the suspended evaluation of genContext using abruptCompletion as the result of the operation that suspended it.
-            // Let result be the completion record returned by the resumed computation.
+            _generatorState = GeneratorState.Completed;
+
+            if (abruptCompletion.Type == CompletionType.Throw)
+            {
+                // TODO handle
+                throw new JavaScriptException(abruptCompletion.Value);
+            }
 
-            return EvaluateGenerator();
+            return IteratorInstance.ValueIteratorPosition.Done;
         }
 
         private GeneratorState GeneratorValidate(JsValue generatorBrand)
@@ -127,27 +151,5 @@ private GeneratorState GeneratorValidate(JsValue generatorBrand)
 
             return _generatorState;
         }
-
-        private JsValue EvaluateGenerator()
-        {
-            var result = _generatorBody.Execute();
-            JsValue resultValue = null;
-            if (result.Type == CompletionType.Normal)
-            {
-                _generatorState = GeneratorState.Completed;
-                resultValue = IteratorInstance.ValueIteratorPosition.Done;
-            }
-            else if (result.Type == CompletionType.Return)
-            {
-                resultValue = result.Value;
-            }
-
-            if (result.Type == CompletionType.Throw)
-            {
-                // TODO handle
-            }
-
-            return resultValue;
-        }
     }
 }

Jint/Native/Iterator/IteratorInstance.cs

@@ -188,7 +188,7 @@ public void Close(CompletionType completion)
                 }
                 if (completion != CompletionType.Throw && !innerResult.IsObject())
                 {
-                    ExceptionHelper.ThrowTypeError(_target.Engine.Realm);
+                    ExceptionHelper.ThrowTypeError(_target.Engine.Realm, "Iterator returned non-object");
                 }
             }
         }