Merge pull request #417 from secvisogram/feat/197-csaf-2.1-mandatory-test-6.1.45

feat: add mandatory test 6.1.45

Author: christopher-exx

README.md

@@ -316,7 +316,6 @@ The following tests are not yet implemented and therefore missing:
 - Mandatory Test 6.1.27.18
 - Mandatory Test 6.1.42
 - Mandatory Test 6.1.44
-- Mandatory Test 6.1.45
 - Mandatory Test 6.1.46
 - Mandatory Test 6.1.47
 - Mandatory Test 6.1.48
@@ -434,6 +433,7 @@ export const mandatoryTest_6_1_39: DocumentTest
 export const mandatoryTest_6_1_40: DocumentTest
 export const mandatoryTest_6_1_41: DocumentTest
 export const mandatoryTest_6_1_43: DocumentTest
+export const mandatoryTest_6_1_45: DocumentTest
 export const mandatoryTest_6_1_52: DocumentTest
 ```
 

csaf_2_1/mandatoryTests.js

@@ -58,4 +58,5 @@ export { mandatoryTest_6_1_39 } from './mandatoryTests/mandatoryTest_6_1_39.js'
 export { mandatoryTest_6_1_40 } from './mandatoryTests/mandatoryTest_6_1_40.js'
 export { mandatoryTest_6_1_41 } from './mandatoryTests/mandatoryTest_6_1_41.js'
 export { mandatoryTest_6_1_43 } from './mandatoryTests/mandatoryTest_6_1_43.js'
+export { mandatoryTest_6_1_45 } from './mandatoryTests/mandatoryTest_6_1_45.js'
 export { mandatoryTest_6_1_52 } from './mandatoryTests/mandatoryTest_6_1_52.js'

csaf_2_1/mandatoryTests/mandatoryTest_6_1_45.js

@@ -0,0 +1,107 @@
+import Ajv from 'ajv/dist/jtd.js'
+import { compareZonedDateTimes } from '../../lib/shared/dateHelper.js'
+
+const ajv = new Ajv()
+
+/*
+  This is the jtd schema that needs to match the input document so that the
+  test is activated. If this schema doesn't match it normally means that the input
+  document does not validate against the csaf json schema or optional fields that
+  the test checks are not present.
+ */
+const inputSchema = /** @type {const} */ ({
+  additionalProperties: true,
+  properties: {
+    document: {
+      additionalProperties: true,
+      properties: {
+        distribution: {
+          additionalProperties: true,
+          properties: {
+            tlp: {
+              additionalProperties: true,
+              properties: {
+                label: { type: 'string' },
+              },
+            },
+          },
+        },
+        tracking: {
+          additionalProperties: true,
+          properties: {
+            revision_history: {
+              elements: {
+                additionalProperties: true,
+                optionalProperties: {
+                  date: { type: 'string' },
+                },
+              },
+            },
+          },
+        },
+      },
+    },
+    vulnerabilities: {
+      elements: {
+        additionalProperties: true,
+        optionalProperties: {
+          disclosure_date: { type: 'string' },
+        },
+      },
+    },
+  },
+})
+
+const validate = ajv.compile(inputSchema)
+
+/**
+ * This implements the mandatory test 6.1.45 of the CSAF 2.1 standard.
+ *
+ * @param {any} doc
+ */
+export function mandatoryTest_6_1_45(doc) {
+  const ctx = {
+    errors:
+      /** @type {Array<{ instancePath: string; message: string }>} */ ([]),
+    isValid: true,
+  }
+  if (!validate(doc)) {
+    return ctx
+  }
+  const status = doc.document.tracking.status
+  const tlpLabel = doc.document.distribution.tlp.label
+  if (!(tlpLabel === 'CLEAR' && (status === 'final' || status === 'interim'))) {
+    return ctx
+  }
+
+  const revisionHistory = doc.document.tracking?.revision_history
+  // sort the revision history (descending) and save the newest entry
+  const newestRevisionHistoryItem = revisionHistory
+    .filter((item) => item.date !== undefined)
+    .sort((a, b) =>
+      compareZonedDateTimes(
+        /** @type {string} */ (b.date),
+        /** @type {string} */ (a.date)
+      )
+    )[0]
+
+  doc.vulnerabilities?.forEach((vulnerability, vulnerabilityIndex) => {
+    const disclosureDate = vulnerability.disclosure_date
+    // compare the disclosure date with the date of the newest item in the revision history
+    if (
+      disclosureDate &&
+      compareZonedDateTimes(
+        disclosureDate,
+        /** @type {string} */ (newestRevisionHistoryItem.date)
+      ) > 0
+    ) {
+      ctx.isValid = false
+      ctx.errors.push({
+        instancePath: `/vulnerabilities/${vulnerabilityIndex}/disclosure_date`,
+        message: `the "status" is ${status}, but the "disclosure date" is newer than the date of the newest item of the revision_history`,
+      })
+    }
+  })
+
+  return ctx
+}

tests/csaf_2_1/mandatoryTest_6_1_45.js

@@ -0,0 +1,60 @@
+import assert from 'node:assert/strict'
+import { mandatoryTest_6_1_45 } from '../../csaf_2_1/mandatoryTests/mandatoryTest_6_1_45.js'
+
+describe('mandatoryTest_6_1_45', function () {
+  it('only runs on relevant documents', function () {
+    assert.equal(mandatoryTest_6_1_45({ document: 'mydoc' }).isValid, true)
+  })
+
+  it('skips status draft', function () {
+    assert.equal(
+      mandatoryTest_6_1_45({
+        document: {
+          distribution: {
+            tlp: {
+              label: 'CLEAR',
+            },
+          },
+          tracking: {
+            revision_history: [{ date: '2024-01-24T10:00:00.000Z' }],
+            status: 'draft',
+          },
+        },
+        vulnerabilities: [
+          {
+            disclosure_date: '2025-01-24T12:34:56.789Z',
+          },
+        ],
+      }).isValid,
+      true
+    )
+  })
+
+  it('skips empty objects', function () {
+    assert.equal(
+      mandatoryTest_6_1_45({
+        document: {
+          distribution: {
+            tlp: {
+              label: 'CLEAR',
+            },
+          },
+          tracking: {
+            revision_history: [
+              {}, // should be ignored
+              { date: '2024-01-24T10:00:00.000Z' },
+            ],
+            status: 'final',
+          },
+        },
+        vulnerabilities: [
+          {}, // should be ignored
+          {
+            disclosure_date: '2025-01-24T12:34:56.789Z',
+          },
+        ],
+      }).isValid,
+      false
+    )
+  })
+})

tests/csaf_2_1/oasis.js

@@ -20,7 +20,6 @@ const excluded = [
   '6.1.37',
   '6.1.42',
   '6.1.44',
-  '6.1.45',
   '6.1.46',
   '6.1.47',
   '6.1.48',