Skip to content
This repository was archived by the owner on Jun 22, 2024. It is now read-only.

Commit 8541c53

Browse files
committed
test(chart): test with existing KEDA and KEDA in sub-chart
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 0a0f241 commit 8541c53

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

.github/workflows/helm-chart-test.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,27 +37,33 @@ jobs:
3737
test-strategy: job
3838
cluster: 'kind'
3939
helm-version: 'v3.10.3'
40+
test-existing-keda: true
4041
- k8s-version: 'v1.26.14'
4142
test-strategy: deployment
4243
cluster: 'kind'
4344
helm-version: 'v3.11.3'
45+
test-existing-keda: true
4446
- k8s-version: 'v1.27.11'
4547
test-strategy: job_https
4648
cluster: 'kind'
4749
helm-version: 'v3.12.3'
50+
test-existing-keda: true
4851
- k8s-version: 'v1.28.7'
4952
test-strategy: job_hostname
5053
cluster: 'minikube'
5154
helm-version: 'v3.13.3'
55+
test-existing-keda: false
5256
- k8s-version: 'v1.29.2'
5357
test-strategy: deployment_https
5458
cluster: 'minikube'
55-
helm-version: 'v3.14.2'
59+
helm-version: 'v3.14.3'
60+
test-existing-keda: false
5661
env:
5762
CLUSTER: ${{ matrix.cluster }}
5863
KUBERNETES_VERSION: ${{ matrix.k8s-version }}
5964
ARTIFACT_NAME: ${{ matrix.k8s-version }}-${{ matrix.test-strategy }}
6065
HELM_VERSION: ${{ matrix.helm-version }}
66+
TEST_EXISTING_KEDA: ${{ matrix.test-existing-keda }}
6167
steps:
6268
- uses: actions/checkout@main
6369
- name: Output Docker info
@@ -101,7 +107,7 @@ jobs:
101107
with:
102108
timeout_minutes: 10
103109
max_attempts: 3
104-
command: CLUSTER=${CLUSTER} KUBERNETES_VERSION=${KUBERNETES_VERSION} NAME=${IMAGE_REGISTRY} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} make chart_cluster_setup
110+
command: CLUSTER=${CLUSTER} KUBERNETES_VERSION=${KUBERNETES_VERSION} NAME=${IMAGE_REGISTRY} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} TEST_EXISTING_KEDA=${TEST_EXISTING_KEDA} make chart_cluster_setup
105111
- name: Test chart template
106112
run: NAME=${IMAGE_REGISTRY} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} make chart_test_template
107113
- name: Test set custom CA certificate
@@ -119,7 +125,7 @@ jobs:
119125
timeout_minutes: 30
120126
max_attempts: 3
121127
command: |
122-
NAME=${IMAGE_REGISTRY} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} make chart_test_autoscaling_${{ matrix.test-strategy }}
128+
NAME=${IMAGE_REGISTRY} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} TEST_EXISTING_KEDA=${TEST_EXISTING_KEDA} make chart_test_autoscaling_${{ matrix.test-strategy }}
123129
- name: Cleanup Kubernetes cluster
124130
if: always()
125131
run: CLUSTER=${CLUSTER} make chart_cluster_cleanup

tests/charts/make/chart_cluster_setup.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ if [ "${CLUSTER}" = "kind" ]; then
7474
done
7575
fi
7676

77-
if [ "${TEST_EXISTING_INGRESS}" = "true" ]; then
77+
if [ "${TEST_EXISTING_KEDA}" = "true" ]; then
7878
echo "Wait for KEDA core to be ready"
7979
kubectl -n ${KEDA_NAMESPACE} wait --for=condition=ready pod -l app.kubernetes.io/instance=${KEDA_NAMESPACE} --timeout 180s
8080
fi

tests/charts/make/chart_setup_env.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ if [ "$(uname -m)" = "x86_64" ]; then
103103
echo "==============================="
104104

105105
echo "Installing Helm for AMD64 / x86_64"
106-
HELM_VERSION=${HELM_VERSION:-"v3.14.2"}
106+
HELM_VERSION=${HELM_VERSION:-"v3.14.3"}
107107
curl -fsSL -o helm.tar.gz https://get.helm.sh/helm-${HELM_VERSION}-linux-amd64.tar.gz
108108
mkdir -p helm
109109
tar -xf helm.tar.gz --strip-components 1 -C helm

0 commit comments

Comments
 (0)