Improve 'cache restore' command

Author: lyoung-confluent

cache-cli/cmd/restore.go

@@ -6,6 +6,7 @@ import (
 	"os"
 	"regexp"
 	"strings"
+	"sync"
 	"time"
 
 	"github.com/semaphoreci/toolbox/cache-cli/pkg/archive"
@@ -67,6 +68,7 @@ func RunRestore(cmd *cobra.Command, args []string) {
 }
 
 func downloadAndUnpack(storage storage.Storage, archiver archive.Archiver, metricsManager metrics.MetricsManager, keys []string) {
+	cachedList := sync.OnceValues(storage.List)
 	for _, rawKey := range keys {
 		key := NormalizeKey(rawKey)
 		if ok, _ := storage.HasKey(key); ok {
@@ -75,7 +77,12 @@ func downloadAndUnpack(storage storage.Storage, archiver archive.Archiver, metri
 			break
 		}
 
-		availableKeys, err := storage.List()
+		// If the key has no regex characters, skip the list/regexp match.
+		if regexp.QuoteMeta(key) == key {
+			continue
+		}
+
+		availableKeys, err := cachedList()
 		utils.Check(err)
 
 		matchingKey := findMatchingKey(availableKeys, key)
@@ -90,13 +97,15 @@ func downloadAndUnpack(storage storage.Storage, archiver archive.Archiver, metri
 }
 
 func findMatchingKey(availableKeys []storage.CacheKey, match string) string {
+	pattern, err := regexp.Compile(match)
+	if err != nil {
+		return ""
+	}
 	for _, availableKey := range availableKeys {
-		isMatch, _ := regexp.MatchString(match, availableKey.Name)
-		if isMatch {
+		if pattern.MatchString(availableKey.Name) {
 			return availableKey.Name
 		}
 	}
-
 	return ""
 }