"numeric" is int|float|string (int|float|numeric-string) not int|float

[kkmuffme]

Currently "numeric" is treated as int|float, however it's actually int|float|string (phpdoc: int|float|numeric-string)

Additionally, this means that the existing is_int|is_float condition it adds atm is wrong. It should be using is_numeric.

[kkmuffme]

I'll provide a PR for it (actually already had it in #1769, but will split it off, just need to fix the tests), I just want to confirm with you before fixing the failing tests for that.

[kkmuffme]

I totally get from where you're coming but the besides the fact that PHP has an built-in is_numeric, the reason why it's important to include "string" here is that you'll otherwise get unexpected behavior similar to php-src's array key string/int cast php/php-src#9029

Therefore I think it's better to keep it "strict" and include string with numeric type

[kukulich]

I’m ok with is_numeric check