Can we officially adopt the 3rd party plugins?

[archisman-panigrahi]

There are three third party plugins in https://github.com/safeeyes/safeeyes-plugins.

They are not packaged in any of the official repositories, and most of the users never get to know about them.

How about we integrate into the safeeyes repo?

We can either copy-paste, or use something like git-submodules. I would prefer the former for simplicity.

Let me know what you think @slgobinath @deltragon

[slgobinath]

Yes that's a great idea. Also it's easy to maintain them if they are part of this repository.

[archisman-panigrahi]

Let me test how they work with the current version. And then I will get back.

[archisman-panigrahi]

The zoom plugin shows the following error

ERROR:root:Error updating the order of on_pre_break plugins
Traceback (most recent call last):
  File "/home/archisman/Documents/GitHub/SafeEyes/safeeyes/plugins/zoom/plugin.py", line 51, in init
    safeeyes = ctx['api']['show_about'].__closure__[0].cell_contents
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
TypeError: 'NoneType' object is not subscriptable
xprop: error: No window with name Zoom Meeting exists!
xprop: error: No window with name as_toolbar exists!
xprop: error: No window with name Zoom Meeting exists!
xprop: error: No window with name as_toolbar exists!

Since it uses xprop, and I am using wayland, it does not work. To fix it, we need to figure out how to find the existence of zoom meeting in Wayland.

[archisman-panigrahi]

The weather plugin requires pyowm, which is not available on Debian. I installed it with pip and added my OpenWeatherMap API Key. However, it does not show any weather info in the break screen at all.

[archisman-panigrahi]

The "use system notifications" plugin is probably unnecessary as safeeyes already uses system notifications as far as I understand.

[archisman-panigrahi]

In my opinion, fixing the "zoom" plugin will benefit a lot of users. The "weather" plugin needs some work, but it is not that important, and "use system notifications" plugin is now unnecessary.

[archisman-panigrahi]

If #802 works out, then we will not need a separate zoom plugin.

[slgobinath]

Also there is a PR safeeyes/safeeyes-plugins#10

If you conclude the existing plugins are already covered or low priority, I will archive that repo to keep the focus here.

[deltragon]

The "use system notifications" plugin is probably unnecessary as safeeyes already uses system notifications as far as I understand.

The point of that plugin, as I understand it, is to use notifications instead of showing the break screen. This is the "least strict" mode, where Safe Eyes is just a reminder that hints you to take a break, but does not force you to.
I do think that's a valid use case for a plugin.

[deltragon]

I agree that #802 is probably a better version of the zoom plugin, as it also works on Wayland.

[deltragon]

Generally, I'm okay with integrating more optional plugins into the main repository. I think I'd also prefer copy-paste over submodules.