From 0baf439552218fbead5e017c4687feb204d77960 Mon Sep 17 00:00:00 2001
From: dhananjaypai08 <dhananjay2002pai@gmail.com>
Date: Fri, 13 Jun 2025 20:23:53 +0530
Subject: [PATCH] fix(contract-warnings): fixing test-contract build stage

---
 test/e2e/data-feeds/BasicDataConsumerV3.t.sol  |  2 +-
 .../data-streams/DataStreamsConsumerFork.t.sol |  4 ++--
 .../smoke/data-feeds/BasicDataConsumerV3.t.sol |  2 +-
 test/unit/data-feeds/DataFeedsUnit.t.sol       | 18 +++++++++---------
 4 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/test/e2e/data-feeds/BasicDataConsumerV3.t.sol b/test/e2e/data-feeds/BasicDataConsumerV3.t.sol
index 1f2885b..1d23156 100644
--- a/test/e2e/data-feeds/BasicDataConsumerV3.t.sol
+++ b/test/e2e/data-feeds/BasicDataConsumerV3.t.sol
@@ -20,7 +20,7 @@ contract BasicDataConsumerV3Test is Test {
         consumer = new BasicDataConsumerV3(ETH_USD_AGGREGATOR_ADDRESS);
     }
 
-    function test_forkSmoke() public {
+    function test_forkSmoke() public view {
         assertEq(vm.activeFork(), ethereumMainnetForkId);
 
         int256 answer = consumer.getChainlinkDataFeedLatestAnswer();
diff --git a/test/e2e/data-streams/DataStreamsConsumerFork.t.sol b/test/e2e/data-streams/DataStreamsConsumerFork.t.sol
index 878f10a..555f6ee 100644
--- a/test/e2e/data-streams/DataStreamsConsumerFork.t.sol
+++ b/test/e2e/data-streams/DataStreamsConsumerFork.t.sol
@@ -65,7 +65,7 @@ contract DataStreamsConsumerForkTest is Test {
         dataStreamsLocalSimulatorFork = new DataStreamsLocalSimulatorFork();
     }
 
-    function preTestHook() public returns (IVerifierProxy, IFeeManager, address, bytes memory) {
+    function preTestHook() public view returns (IVerifierProxy, IFeeManager, address, bytes memory) {
         assertEq(vm.activeFork(), arbitrumSepoliaForkId);
 
         Register.NetworkDetails memory networkDetails = dataStreamsLocalSimulatorFork.getNetworkDetails(block.chainid);
@@ -79,7 +79,7 @@ contract DataStreamsConsumerForkTest is Test {
         return (verifierProxy, feeManager, rewardManager, reportData);
     }
 
-    function postTestHook(ReportVersions.ReportV3 memory verifiedReport) public {
+    function postTestHook(ReportVersions.ReportV3 memory verifiedReport) public view {
         assertEq(verifiedReport.feedId, EXPECTED_REPORT.feedId);
         assertEq(verifiedReport.validFromTimestamp, EXPECTED_REPORT.validFromTimestamp);
         assertEq(verifiedReport.observationsTimestamp, EXPECTED_REPORT.observationsTimestamp);
diff --git a/test/smoke/data-feeds/BasicDataConsumerV3.t.sol b/test/smoke/data-feeds/BasicDataConsumerV3.t.sol
index 3c50ab8..9084a03 100644
--- a/test/smoke/data-feeds/BasicDataConsumerV3.t.sol
+++ b/test/smoke/data-feeds/BasicDataConsumerV3.t.sol
@@ -20,7 +20,7 @@ contract BasicDataConsumerV3Test is Test {
         consumer = new BasicDataConsumerV3(address(mockEthUsdAggregator));
     }
 
-    function test_smoke() public {
+    function test_smoke() public view {
         int256 answer = consumer.getChainlinkDataFeedLatestAnswer();
         assertEq(answer, initialAnswer, "answer should be equal to initialAnswer");
     }
diff --git a/test/unit/data-feeds/DataFeedsUnit.t.sol b/test/unit/data-feeds/DataFeedsUnit.t.sol
index 0a21961..7892510 100644
--- a/test/unit/data-feeds/DataFeedsUnit.t.sol
+++ b/test/unit/data-feeds/DataFeedsUnit.t.sol
@@ -25,17 +25,17 @@ contract BasicDataConsumerV3Test is Test {
         mockOffchainAggregator = MockOffchainAggregator(mockAggregator.aggregator());
     }
 
-    function test_shouldReturnDecimals() public {
+    function test_shouldReturnDecimals() public view {
         uint8 result = mockAggregator.decimals();
         assertEq(result, decimals);
     }
 
-    function test_shouldReturnAnswerByRoundId() public {
+    function test_shouldReturnAnswerByRoundId() public view {
         int256 result = mockAggregator.getAnswer(initialRoundId);
         assertEq(result, initialAnswer);
     }
 
-    function test_shouldReturnRoundDataByRoundId() public {
+    function test_shouldReturnRoundDataByRoundId() public view {
         (uint80 roundId, int256 answer, uint256 startedAt, uint256 updatedAt, uint80 answeredInRound) =
             mockAggregator.getRoundData(initialRoundId);
 
@@ -46,7 +46,7 @@ contract BasicDataConsumerV3Test is Test {
         assertEq(answeredInRound, initialRoundId);
     }
 
-    function test_shouldReturnLatestRoundData() public {
+    function test_shouldReturnLatestRoundData() public view {
         (uint80 roundId, int256 answer, uint256 startedAt, uint256 updatedAt, uint80 answeredInRound) =
             mockAggregator.latestRoundData();
 
@@ -57,22 +57,22 @@ contract BasicDataConsumerV3Test is Test {
         assertEq(answeredInRound, initialRoundId);
     }
 
-    function test_shouldReturnTimestampByRoundId() public {
+    function test_shouldReturnTimestampByRoundId() public view {
         uint256 result = mockAggregator.getTimestamp(initialRoundId);
         assertEq(result, deploymentTimestamp);
     }
 
-    function test_shouldReturnLatestAnswer() public {
+    function test_shouldReturnLatestAnswer() public view {
         int256 result = mockAggregator.latestAnswer();
         assertEq(result, initialAnswer);
     }
 
-    function test_shouldReturnLatestTimestamp() public {
+    function test_shouldReturnLatestTimestamp() public view {
         uint256 result = mockAggregator.latestTimestamp();
         assertEq(result, deploymentTimestamp);
     }
 
-    function test_shouldReturnLatestRound() public {
+    function test_shouldReturnLatestRound() public view {
         uint256 result = mockAggregator.latestRound();
         assertEq(result, initialRoundId);
     }
@@ -146,7 +146,7 @@ contract BasicDataConsumerV3Test is Test {
         assertEq(result, newAnswer);
     }
 
-    function test_shouldReturnMinAndMaxAnswers() public {
+    function test_shouldReturnMinAndMaxAnswers() public view {
         int192 minAnswer = 1;
         int192 maxAnswer = 95780971304118053647396689196894323976171195136475135; // type(uint176).max