Skip to content

Conversation

@weifangc
Copy link

@weifangc weifangc commented Nov 17, 2025

Closes #ISSUE_NUMBER_GOES_HERE

Description

fix some minor issues in comments

Changes

  • High level
  • changes that
  • you made

Steps to Test

  1. Steps
  2. to
  3. test

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2025

🦋 Changeset detected

Latest commit: ae7f6bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@chainlink/token-allocation-adapter Patch
@chainlink/cryptocompare-adapter Patch
@chainlink/generic-api-adapter Patch
@chainlink/ea-reference-data-reader Patch
@chainlink/apy-finance-adapter Patch
@chainlink/bsol-price-adapter Patch
@chainlink/crypto-volatility-index-adapter Patch
@chainlink/curve-3pool-adapter Patch
@chainlink/defi-dozen-adapter Patch
@chainlink/defi-pulse-adapter Patch
@chainlink/dxdao-adapter Patch
@chainlink/linear-finance-adapter Patch
@chainlink/savax-price-adapter Patch
@chainlink/set-token-index-adapter Patch
@chainlink/vesper-adapter Patch
@chainlink/xsushi-price-adapter Patch
@chainlink/market-closure-adapter Patch
@chainlink/outlier-detection-adapter Patch
@chainlink/rocket-pool-adapter Patch
@chainlink/the-graph-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mxiao-cll
mxiao-cll previously approved these changes Nov 17, 2025
@mxiao-cll
Copy link
Contributor

Please use signed commits

@weifangc
Copy link
Author

Please use signed commits

@mxiao-cll Thanks.

Rebased and signed. Please review it again.

mxiao-cll
mxiao-cll previously approved these changes Nov 18, 2025
@mxiao-cll mxiao-cll enabled auto-merge (squash) November 18, 2025 14:49
@mxiao-cll
Copy link
Contributor

Looks like you need to create a changeset, even if this is just changing comments

auto-merge was automatically disabled November 24, 2025 09:38

Head branch was pushed to by a user without write access

@weifangc
Copy link
Author

Looks like you need to create a changeset, even if this is just changing comments

Thanks. @mxiao-cll

Added and rebased.

Please review it again.

@mxiao-cll mxiao-cll self-requested a review November 24, 2025 13:34
@mxiao-cll
Copy link
Contributor

Need to run yarn format:fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants