Skip to content

Pczajka fix aio wif #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: dev/aio-connector
Choose a base branch
from
Open

Pczajka fix aio wif #2678

wants to merge 6 commits into from
+72 −10

Conversation

@sfc-gh-pczajka
Copy link
Collaborator

@sfc-gh-pczajka sfc-gh-pczajka commented Nov 26, 2025

This PR:

  • adds aioboto and aiobotocore dependency if [aio] extra is specified, if SNOWFLAKE_NO_BOTO flag is not provided (checked by extra tests in test installation github check)
  • fixes bug in AWS WIF async implementation
  • asjusts async tests to the fix

@sfc-gh-pczajka sfc-gh-pczajka requested review from a team as code owners November 26, 2025 15:55
@github-actions
Copy link

github-actions bot commented Nov 26, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-pczajka sfc-gh-pczajka changed the base branch from main to dev/aio-connector November 26, 2025 15:55
@sfc-gh-pczajka
Fix error creation
b48cb28
@sfc-gh-pczajka
Fix setup.py
369f946
@sfc-gh-pczajka
Add step to installation check
d965a47
@sfc-gh-pczajka
Fix aiobotocore credentials for WIF AWS attestation
5433ee2 
Freeze aiobotocore credentials before passing to synchronous botocore signing.
Aiobotocore returns AioRefreshableCredentials which need to be frozen before
use with synchronous SigV4Auth.
@sfc-gh-pczajka
Fix async credentials mock for WIF unit tests
122df5a 
Create AsyncCredentialsWrapper to properly mock aiobotocore credentials
with async get_frozen_credentials() method. This allows unit tests to
pass while the production code correctly handles real aiobotocore
AioRefreshableCredentials.
sfc-gh-turbaszek
sfc-gh-turbaszek reviewed Nov 27, 2025
View reviewed changes
sfc-gh-turbaszek
sfc-gh-turbaszek reviewed Nov 27, 2025
View reviewed changes
sfc-gh-turbaszek
sfc-gh-turbaszek reviewed Nov 27, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-pczajka @sfc-gh-turbaszek