Skip to content

Commit 9a229cf

Browse files
committed
Merge branch 'master' into update/scala-xml-2.4.0
2 parents c8fabb3 + f838f35 commit 9a229cf

File tree

6 files changed

+15
-16
lines changed

6 files changed

+15
-16
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,6 @@ project/boot
1212
.bsp
1313
.db
1414
.env
15+
16+
.metals
17+
.bloop

build.sbt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import scoverage.ScoverageKeys.*
99
import scala.sys.process.Process
1010

1111
val v2_12 = "2.12.20"
12-
val v2_13 = "2.13.15"
13-
val v3 = "3.3.4"
12+
val v2_13 = "2.13.16"
13+
val v3 = "3.3.6"
1414

1515
lazy val resolvedScalaVersion =
1616
sys.env.get("SCALA_MAJOR_VERSION") match {
@@ -27,7 +27,7 @@ lazy val yarnTask = inputKey[Unit]("Run yarn with arguments")
2727
lazy val ensureDockerBuildx = taskKey[Unit]("Ensure that docker buildx configuration exists")
2828
lazy val dockerBuildWithBuildx = taskKey[Unit]("Build docker images using buildx")
2929

30-
val config = "com.typesafe" % "config" % "1.4.3"
30+
val config = "com.typesafe" % "config" % "1.4.4"
3131
val pureConfig = "com.github.pureconfig" %% "pureconfig-core" % "0.17.8"
3232
val scalaXml = "org.scala-lang.modules" %% "scala-xml" % "2.4.0"
3333

@@ -41,7 +41,7 @@ val awaitility = "org.awaitility" % "awaitility-scala" % "4.3.0"
4141
val amazonJavaSdkSqs = "com.amazonaws" % "aws-java-sdk-sqs" % "1.12.699" exclude ("commons-logging", "commons-logging")
4242
val amazonJavaV2SdkSqs = "software.amazon.awssdk" % "sqs" % "2.25.60"
4343

44-
val pekkoVersion = "1.1.3"
44+
val pekkoVersion = "1.1.5"
4545
val pekkoHttpVersion = "1.1.0"
4646
val pekkoActor = "org.apache.pekko" %% "pekko-actor" % pekkoVersion
4747
val pekkoSlf4j = "org.apache.pekko" %% "pekko-slf4j" % pekkoVersion
@@ -83,7 +83,6 @@ val buildSettings = commonSmlBuildSettings ++ ossPublishSettings ++ Seq(
8383
libraryDependencies += scalaXml,
8484
dependencyOverrides := pekko100verrides,
8585
parallelExecution := false,
86-
sonatypeProfileName := "org.elasticmq",
8786
// workaround for: https://github.com/sbt/sbt/issues/692
8887
Test / fork := true,
8988
assembly / assemblyMergeStrategy := {

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version=1.11.0
1+
sbt.version=1.11.3

project/plugins.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// required for sbt-github-release resolution
22
resolvers += "Era7 maven releases" at "https://s3-eu-west-1.amazonaws.com/releases.era7.com"
33

4-
val sbtSoftwaremillVersion = "2.0.25"
4+
val sbtSoftwaremillVersion = "2.1.0"
55
addSbtPlugin("com.softwaremill.sbt-softwaremill" % "sbt-softwaremill-common" % sbtSoftwaremillVersion)
66
addSbtPlugin("com.softwaremill.sbt-softwaremill" % "sbt-softwaremill-publish" % sbtSoftwaremillVersion)
77
addSbtPlugin("com.github.sbt" % "sbt-native-packager" % "1.11.1")

rest/rest-sqs-testing-amazon-java-sdk/src/test/scala/org/elasticmq/rest/sqs/AmazonJavaSdkTestSuite.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -445,10 +445,10 @@ class AmazonJavaSdkTestSuite extends SqsClientServerCommunication with Matchers
445445
client.sendMessage(new SendMessageRequest(fifoQueueUrl, "A body"))
446446
)
447447

448-
// Regular queues don't allow message groups
449-
assertInvalidParameterQueueTypeException("MessageGroupId")(
450-
client.sendMessage(new SendMessageRequest(regularQueueUrl, "A body").withMessageGroupId("group-1"))
451-
)
448+
// Regular queues now allow message groups
449+
// Test that sending MessageGroupId to regular queue works
450+
val result = client.sendMessage(new SendMessageRequest(regularQueueUrl, "A body").withMessageGroupId("group-1"))
451+
result should not be null
452452
}
453453

454454
test("FIFO queues do not support delaying individual messages") {

rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/SendMessageDirectives.scala

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,17 +88,14 @@ trait SendMessageDirectives {
8888
.fold(error => throw SQSException.invalidAttributeValue("MessageBody", Some(error)), identity)
8989

9090
val messageGroupId = parameters.MessageGroupId match {
91-
// MessageGroupId is only supported for FIFO queues
92-
case Some(v) if !queueData.isFifo => throw SQSException.invalidQueueTypeParameter(MessageGroupIdParameter)
93-
9491
// MessageGroupId is required for FIFO queues
9592
case None if queueData.isFifo => throw SQSException.missingParameter(MessageGroupIdParameter)
9693

97-
// Ensure the given value is valid
94+
// Ensure the given value is valid (for both FIFO and standard queues)
9895
case Some(id) if !isValidFifoPropertyValue(id) =>
9996
throw SQSException.invalidAlphanumericalPunctualParameterValue(MessageGroupIdParameter)
10097

101-
// This must be a correct value (or this isn't a FIFO queue and no value is required)
98+
// This must be a correct value or None
10299
case m => m
103100
}
104101

0 commit comments

Comments
 (0)