refactor: 소식지 단일 좋아요 여부 확인 API 제거 (#455)

* refactor: 소식지 목록 조회 시 isLike 추가

- 로그인하지 않은 사용자에게는 isLike를 응답하지 않도록

* refactor: 소식지 목록 조회 시 좋아요 여부 확인 로직 추가

- 로그인한 사용자와 로그인하지 않은 사용자를 구분
- @Authorizeduser(required = false) 활용
- Set을 활용하여 n + 1 문제 해결

* test: 소식지 관련 fixture 추가

* test: 소식지 조회 서비스 테스트 추가

* refactor: 사용하지 않는 api 제거

* refactor: 쿼리 2 -> 1로 개선

- jpql 프로젝션 활용

* style: isLike -> isLiked로 변경

* test: 검증 구체화

- 사이즈가 아닌 실제 id가 존재하는지 확인하도록

* refactor: from -> of로 변경

Author: Gyuhyeok99

src/main/java/com/example/solidconnection/news/controller/NewsController.java

@@ -1,7 +1,6 @@
 package com.example.solidconnection.news.controller;
 
 import com.example.solidconnection.common.resolver.AuthorizedUser;
-import com.example.solidconnection.news.dto.LikedNewsResponse;
 import com.example.solidconnection.news.dto.NewsCommandResponse;
 import com.example.solidconnection.news.dto.NewsCreateRequest;
 import com.example.solidconnection.news.dto.NewsListResponse;
@@ -37,9 +36,10 @@ public class NewsController {
     // todo: 추후 Slice 적용
     @GetMapping
     public ResponseEntity<NewsListResponse> findNewsBySiteUserId(
-            @RequestParam(value = "site-user-id") Long siteUserId
+            @AuthorizedUser(required = false) Long siteUserId,
+            @RequestParam(value = "author-id") Long authorId
     ) {
-        NewsListResponse newsListResponse = newsQueryService.findNewsBySiteUserId(siteUserId);
+        NewsListResponse newsListResponse = newsQueryService.findNewsByAuthorId(siteUserId, authorId);
         return ResponseEntity.ok(newsListResponse);
     }
 
@@ -80,15 +80,6 @@ public ResponseEntity<NewsCommandResponse> deleteNewsById(
         return ResponseEntity.ok(newsCommandResponse);
     }
 
-    @GetMapping("/{news-id}/like")
-    public ResponseEntity<LikedNewsResponse> isNewsLiked(
-            @AuthorizedUser long siteUserId,
-            @PathVariable("news-id") Long newsId
-    ) {
-        LikedNewsResponse likedNewsResponse = newsLikeService.isNewsLiked(siteUserId, newsId);
-        return ResponseEntity.ok(likedNewsResponse);
-    }
-
     @PostMapping("/{news-id}/like")
     public ResponseEntity<Void> addNewsLike(
             @AuthorizedUser long siteUserId,

src/main/java/com/example/solidconnection/news/dto/LikedNewsResponse.java

@@ -1,6 +1,9 @@
 package com.example.solidconnection.news.dto;
 
+import static com.fasterxml.jackson.annotation.JsonInclude.Include.NON_NULL;
+
 import com.example.solidconnection.news.domain.News;
+import com.fasterxml.jackson.annotation.JsonInclude;
 import java.time.ZonedDateTime;
 
 public record NewsResponse(
@@ -9,16 +12,21 @@ public record NewsResponse(
         String description,
         String thumbnailUrl,
         String url,
+
+        @JsonInclude(NON_NULL)
+        Boolean isLiked,
+
         ZonedDateTime updatedAt
 ) {
 
-    public static NewsResponse from(News news) {
+    public static NewsResponse of(News news, Boolean isLiked) {
         return new NewsResponse(
                 news.getId(),
                 news.getTitle(),
                 news.getDescription(),
                 news.getThumbnailUrl(),
                 news.getUrl(),
+                isLiked,
                 news.getUpdatedAt()
         );
     }

src/main/java/com/example/solidconnection/news/dto/NewsResponse.java

@@ -1,10 +1,11 @@
 package com.example.solidconnection.news.repository;
 
 import com.example.solidconnection.news.domain.News;
+import com.example.solidconnection.news.repository.custom.NewsCustomRepository;
 import java.util.List;
 import org.springframework.data.jpa.repository.JpaRepository;
 
-public interface NewsRepository extends JpaRepository<News, Long> {
+public interface NewsRepository extends JpaRepository<News, Long>, NewsCustomRepository {
 
     List<News> findAllBySiteUserIdOrderByUpdatedAtDesc(long siteUserId);
 }

src/main/java/com/example/solidconnection/news/repository/NewsRepository.java

@@ -0,0 +1,9 @@
+package com.example.solidconnection.news.repository.custom;
+
+import com.example.solidconnection.news.dto.NewsResponse;
+import java.util.List;
+
+public interface NewsCustomRepository {
+
+    List<NewsResponse> findNewsByAuthorIdWithLikeStatus(long authorId, Long siteUserId);
+}

src/main/java/com/example/solidconnection/news/repository/custom/NewsCustomRepository.java

@@ -0,0 +1,38 @@
+package com.example.solidconnection.news.repository.custom;
+
+import com.example.solidconnection.news.dto.NewsResponse;
+import jakarta.persistence.EntityManager;
+import java.util.List;
+import lombok.RequiredArgsConstructor;
+import org.springframework.stereotype.Repository;
+
+@Repository
+@RequiredArgsConstructor
+public class NewsCustomRepositoryImpl implements NewsCustomRepository {
+
+    private final EntityManager entityManager;
+
+    @Override
+    public List<NewsResponse> findNewsByAuthorIdWithLikeStatus(long authorId, Long siteUserId) {
+        String jpql = """
+                      SELECT new com.example.solidconnection.news.dto.NewsResponse(
+                          n.id,
+                          n.title,
+                          n.description,
+                          n.thumbnailUrl,
+                          n.url,
+                          CASE WHEN ln.id IS NOT NULL THEN true ELSE false END,
+                          n.updatedAt
+                      )
+                      FROM News n
+                      LEFT JOIN LikedNews ln ON n.id = ln.newsId AND ln.siteUserId = :siteUserId
+                      WHERE n.siteUserId = :authorId
+                      ORDER BY n.updatedAt DESC
+                      """;
+
+        return entityManager.createQuery(jpql, NewsResponse.class)
+                .setParameter("authorId", authorId)
+                .setParameter("siteUserId", siteUserId)
+                .getResultList();
+    }
+}

src/main/java/com/example/solidconnection/news/repository/custom/NewsCustomRepositoryImpl.java

@@ -6,7 +6,6 @@
 
 import com.example.solidconnection.common.exception.CustomException;
 import com.example.solidconnection.news.domain.LikedNews;
-import com.example.solidconnection.news.dto.LikedNewsResponse;
 import com.example.solidconnection.news.repository.LikedNewsRepository;
 import com.example.solidconnection.news.repository.NewsRepository;
 import lombok.RequiredArgsConstructor;
@@ -20,15 +19,6 @@ public class NewsLikeService {
     private final NewsRepository newsRepository;
     private final LikedNewsRepository likedNewsRepository;
 
-    @Transactional(readOnly = true)
-    public LikedNewsResponse isNewsLiked(long siteUserId, long newsId) {
-        if (!newsRepository.existsById(newsId)) {
-            throw new CustomException(NEWS_NOT_FOUND);
-        }
-        boolean isLike = likedNewsRepository.existsByNewsIdAndSiteUserId(newsId, siteUserId);
-        return LikedNewsResponse.of(isLike);
-    }
-
     @Transactional
     public void addNewsLike(long siteUserId, long newsId) {
         if (!newsRepository.existsById(newsId)) {

src/main/java/com/example/solidconnection/news/service/NewsLikeService.java

@@ -1,6 +1,5 @@
 package com.example.solidconnection.news.service;
 
-import com.example.solidconnection.news.domain.News;
 import com.example.solidconnection.news.dto.NewsListResponse;
 import com.example.solidconnection.news.dto.NewsResponse;
 import com.example.solidconnection.news.repository.NewsRepository;
@@ -16,11 +15,19 @@ public class NewsQueryService {
     private final NewsRepository newsRepository;
 
     @Transactional(readOnly = true)
-    public NewsListResponse findNewsBySiteUserId(long siteUserId) {
-        List<News> newsList = newsRepository.findAllBySiteUserIdOrderByUpdatedAtDesc(siteUserId);
-        List<NewsResponse> newsResponseList = newsList.stream()
-                .map(NewsResponse::from)
-                .toList();
+    public NewsListResponse findNewsByAuthorId(Long siteUserId, long authorId) {
+        // 로그인하지 않은 경우
+        if (siteUserId == null) {
+            List<NewsResponse> newsResponseList = newsRepository.findAllBySiteUserIdOrderByUpdatedAtDesc(authorId)
+                    .stream()
+                    .map(news -> NewsResponse.of(news, null))
+                    .toList();
+            return NewsListResponse.from(newsResponseList);
+        }
+
+        // 로그인한 경우
+        List<NewsResponse> newsResponseList = newsRepository.findNewsByAuthorIdWithLikeStatus(authorId, siteUserId);
+
         return NewsListResponse.from(newsResponseList);
     }
 }

src/main/java/com/example/solidconnection/news/service/NewsQueryService.java

@@ -0,0 +1,19 @@
+package com.example.solidconnection.news.fixture;
+
+import com.example.solidconnection.news.domain.LikedNews;
+import lombok.RequiredArgsConstructor;
+import org.springframework.boot.test.context.TestComponent;
+
+@TestComponent
+@RequiredArgsConstructor
+public class LikedNewsFixture {
+
+    private final LikedNewsFixtureBuilder likedNewsFixtureBuilder;
+
+    public LikedNews 소식지_좋아요(long newsId, long siteUserId) {
+        return likedNewsFixtureBuilder.likedNews()
+                .newsId(newsId)
+                .siteUserId(siteUserId)
+                .create();
+    }
+}

src/test/java/com/example/solidconnection/news/fixture/LikedNewsFixture.java

@@ -0,0 +1,36 @@
+package com.example.solidconnection.news.fixture;
+
+import com.example.solidconnection.news.domain.LikedNews;
+import com.example.solidconnection.news.repository.LikedNewsRepository;
+import lombok.RequiredArgsConstructor;
+import org.springframework.boot.test.context.TestComponent;
+
+@TestComponent
+@RequiredArgsConstructor
+public class LikedNewsFixtureBuilder {
+
+    private final LikedNewsRepository likedNewsRepository;
+
+    private long newsId;
+
+    private long siteUserId;
+
+    public LikedNewsFixtureBuilder likedNews() {
+        return new LikedNewsFixtureBuilder(likedNewsRepository);
+    }
+
+    public LikedNewsFixtureBuilder newsId(long newsId) {
+        this.newsId = newsId;
+        return this;
+    }
+
+    public LikedNewsFixtureBuilder siteUserId(long siteUserId) {
+        this.siteUserId = siteUserId;
+        return this;
+    }
+
+    public LikedNews create() {
+        LikedNews likedNews = new LikedNews(newsId, siteUserId);
+        return likedNewsRepository.save(likedNews);
+    }
+}