Skip to content

PersonShape #16

Open
Open
@elf-pavlik

Description

@elf-pavlik

This is the first one I will adjust solid-efforts to use. I have a few comments under the snippet 👇

In #15 we have

shape :PersonShape -> ex:Person ;
	sh:name "Person"@en {
	ex:name xsd:string [1..1] %
		sh:name "name"@en
	% .
	ex:contactEmail xsd:string [0..1] pattern="^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+.[a-zA-Z]{2,}$" %
		sh:name "contact email"@en ;
		sh:description "if you wish to share the email privately to ODI, leave this blank & contact [email protected]"
	% .
	ex:webid xsd:string [0..1] %
		sh:name "WebID"
	% .
	ex:forumHandle xsd:string [0..1] %
		sh:name "forum handle" ;
		sh:description "your handle/nick on the Solid Forum"
	% .
	ex:matrixHandle xsd:string [0..1] %
		sh:name "matrix handle" ;
		sh:description "your handle/nick in the Matrix chatrooms"
	% .
	ex:description xsd:string [0..1] maxLength=280 %
		sh:name "description"@en
	% .
	ex:logo IRI [0..1] %
		sh:name "logo"@en
	% .
	ex:landingPage IRI [0..1] %
		sh:name "landing page"@en
	% .
	ex:repository IRI [0..1] %
		sh:name "repository"@en
	% .
	ex:resourcesWanted xsd:string maxLength=280 %
		sh:name "resources wanted"@en ;
		sh:description "funding, employees, interns, partners, separate multiple with a blank line"
	% .
	ex:resourcesOffered xsd:string maxLength=280 %
		sh:name "resources offered"@en ;
		sh:description "funding, mentorship, collaboration, offered; separate multiple with a blank line"
	% .
}
  1. I agree that name should be the only required property
  2. logo & description SGTM, I will most likely just use those two and the name for what I need ATM
  3. I don't see need for webid as property, if someone has WebID we will simply use it as the subject/object (related to Unique temporary identifiers #7)
  4. I find forumHandle too specific, instead I would look for a generic property in lines of rel-me and then apps could use regex to detect one for the solid forum. This looks pretty easy https://forum.solidproject.org/u/elf-pavlik, if we really want to define something very specific solidForumHandle for Solid Forum, it should at least be an IRI rather than a string. In the long run we should allow setting WebID in the discourse running Solid Forum so that information can be extracted from there. In that case this specific property could become archaic.
  5. matrixHandle sounds ok since it is protocol specific, in contrast to Solid Forum. It also seems to have a very specific format MXID (eg. @elf-pavlik-53f689c8163965c9bc1ffb15:gitter.im) can we add a regex to enforce it?
  6. repository i honestly don't know what that is supposed to mean, something like https://github.com/msporny/dna ? 😉
  7. resourcesWanted & resourcesOffered, I think eventually they will need to become IRIs and shapes based on something like https://schema.org/Offer and https://schema.org/Demand I think this will be a major task on its own. As long as people realize that we will not be able to migrate their tweet size strings and they will need to recreate that part once it gets changed, I would just leave it as is and create a cleaner approach when we are ready to focus on it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions