Support external verification status tracking in job verification page #14
Conversation
✅ Deploy Preview for verify-sourcify-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
app/routes/jobs.$jobId.tsx
Outdated
| <p className="text-sm text-gray-500">Statuses refresh every {EXTERNAL_VERIFICATION_STATUS_REFRESH_RATE_SECONDS} seconds.</p> | ||
| </div> | ||
| <div className="space-y-4"> | ||
| {Object.entries(jobData.externalVerifications) |
There was a problem hiding this comment.
Can we order the verifiers? I would do it by adoption, which should be in this order: Etherscan, Blockscout, Routescan.
There was a problem hiding this comment.
I would actually put Etherscan last because it's not part of the verifier alliance :)
app/routes/jobs.$jobId.tsx
Outdated
| </div> | ||
| )} | ||
|
|
||
| {/* External Verifier Statuses */} |
There was a problem hiding this comment.
If it's easy, can we maybe refactor the new part of the page into a component? The JobDetails component grew quite big imo
| const externalVerifierStatusesRef = useRef<ExternalVerifierStatusMap>({}); | ||
| const { serverUrl } = useServerConfig(); | ||
| const hasExternalVerificationData = hasAllRequiredExternalVerifications(jobData?.externalVerifications); | ||
| const isJobFullyCompleted = Boolean(jobData?.isJobCompleted) && hasExternalVerificationData; |
There was a problem hiding this comment.
Is there a scenario where we wouldn't store data for all external verifiers? I think requiring the data to be present isn't perfect.
There was a problem hiding this comment.
I found this also makes the page refetching data for old jobs which don't have external verifications for an indefinite amount of time.
There was a problem hiding this comment.
Is there a scenario where we wouldn't store data for all external verifiers? I think requiring the data to be present isn't perfect.
I think we don't have to support the case in which we change settings in Sourcify (e.g. we disable a specific verifier). UI should just mirror whatever configuration is currently in use. If we change the config of server, then we manually update also UI. The alternative would be to returned the list of enabled storage services so the UI can adapt.
I found this also makes the page refetching data for old jobs which don't have external verifications for an indefinite amount of time.
Right it makes sense. I think we should limit with a maximum amount of re-fetch
marcocastignoli
moved this from Sprint - In Progress
to Sprint - Needs Review
in Sourcify Public
See argotorg/sourcify#2425