Skip to content

Commit db94e84

Browse files
committed
shift some things around
Signed-off-by: Caleb Schoepp <[email protected]>
1 parent ee6f41f commit db94e84

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

tests/integration.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1399,7 +1399,6 @@ route = "/..."
13991399
}
14001400
}
14011401

1402-
// TODO(Reviewer): How can I move this to a new file? I wasn't able to get the imports to work out.
14031402
mod otel_integration_tests {
14041403
use fake_opentelemetry_collector::FakeCollectorServer;
14051404
use std::time::Duration;

tests/test-components/components/wasi-otel-tracing/src/lib.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,6 @@ fn nested_spans(_req: Request, _params: Params) -> Response {
5252
Response::new(200, "")
5353
}
5454

55-
// TODO: Test what happens if start is called but not end
56-
// TODO: Test what happens if end is called but not start
57-
// TODO: What happens if child span outlives parent
58-
5955
fn setting_attributes(_req: Request, _params: Params) -> Response {
6056
let (tracer, _ctx) = setup_tracer(true);
6157
tracer.in_span("setting_attributes", |cx| {
@@ -128,3 +124,7 @@ async fn make_request() {
128124
.build();
129125
let _res: Response = spin_sdk::http::send(req).await.unwrap();
130126
}
127+
128+
// TODO: Test what happens if start is called but not end
129+
// TODO: Test what happens if end is called but not start
130+
// TODO: What happens if child span outlives parent

0 commit comments

Comments
 (0)