Merge pull request #368 from splunk/remove-recordtype-library

remove recordtype library

Author: Ryan Faircloth

poetry.lock

@@ -42,7 +42,6 @@ lovely-pytest-docker = "*"
 pytest-mock = "^3.5.1"
 pytest-cov = "^2.11.1"
 requests-mock = "^1.8.0"
-recordtype = "^1.3"
 freezegun = "^1.1.0"
 
 [tool.poetry.plugins]

pyproject.toml

@@ -1,11 +1,15 @@
 import pytest
-from recordtype import recordtype
+from dataclasses import dataclass
 from .test_hec_event_metric_raw_ingestor import HEC_URI
 
-SampleEvent = recordtype(
-    "SampleEvent",
-    ["event", "metadata", "sample_name", ("key_fields", None), ("time_values", None)],
-)
+
+@dataclass()
+class SampleEvent:
+    event: str
+    metadata: dict
+    sample_name: str
+    key_fields: dict = None
+    time_values: list = None
 
 
 @pytest.fixture()

tests/unit/tests_standard_lib/test_event_ingestors/conftest.py

@@ -1,27 +1,27 @@
 import pytest
 from unittest.mock import MagicMock, call, patch
-from recordtype import recordtype
+from dataclasses import dataclass
 from pytest_splunk_addon.standard_lib.event_ingestors.requirement_event_ingester import (
     RequirementEventIngestor,
     ET,
 )
 
 
 module = "pytest_splunk_addon.standard_lib.event_ingestors.requirement_event_ingester"
-sample_event = recordtype(
-    "SampleEvent",
-    ["event", "metadata", "sample_name", ("key_fields", None), ("time_values", None)],
-)
 
 
-@pytest.fixture()
-def sample_event_mock(monkeypatch):
-    monkeypatch.setattr(f"{module}.SampleEvent", sample_event)
+@dataclass()
+class SampleEvent:
+    event: str
+    metadata: dict
+    sample_name: str
+    key_fields: dict = None
+    time_values: list = None
 
 
 @pytest.fixture()
-def src_regex_mock(monkeypatch):
-    monkeypatch.setattr(f"{module}.SrcRegex", src_regex)
+def sample_event_mock(monkeypatch):
+    monkeypatch.setattr(f"{module}.SampleEvent", SampleEvent)
 
 
 @pytest.fixture()
@@ -116,12 +116,12 @@ def test_events_can_be_obtained(
     mock_object("os.listdir", return_value=["sample.log"])
     req = RequirementEventIngestor("fake_path")
     assert req.get_events() == [
-        sample_event(
+        SampleEvent(
             event="event: session created",
             metadata={"input_type": "syslog", "index": "main"},
             sample_name="requirement_test",
         ),
-        sample_event(
+        SampleEvent(
             event="event: session closed",
             metadata={"input_type": "syslog", "index": "main"},
             sample_name="requirement_test",