fix(MessageChatMemoryAdvisor): Fix incorrect prompt position for system messages #3520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ahoo-Wang
commented
Jun 12, 2025
Ahoo-Wang
commented
- First position of prompt to insert system message
- Prioritize system messages in conversation history
- First position of prompt to insert system message - Prioritize system messages in conversation history Signed-off-by: Ahoo Wang <[email protected]>
apappascs
reviewed
Jun 12, 2025
...-chat/src/main/java/org/springframework/ai/chat/client/advisor/MessageChatMemoryAdvisor.java
Outdated
Show resolved
Hide resolved
- Replace stream-based instruction processing with a for loop - Improve readability and performance by avoiding unnecessary stream operations Signed-off-by: Ahoo Wang <[email protected]>
yuluo-yx
reviewed
Jun 14, 2025
| List<Message> processedMessages = new ArrayList<>(memoryMessages); | ||
| processedMessages.addAll(chatClientRequest.prompt().getInstructions()); | ||
|
|
||
| List<Message> processedMessages = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
Why put system in the first place? In my opinion, system indicates LLMS, and all subsequent conversations are based on system.
And from https://openai.com/index/gpt-4-api-general-availability/, system and user message do not have the same function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.