Provide a way for developers to set a custom StreamFunctionCallingHelper #3607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sdghchj <[email protected]>
…elper Signed-off-by: sdghchj <[email protected]>
Signed-off-by: sdghchj <[email protected]>
Signed-off-by: sdghchj <[email protected]>
Signed-off-by: sdghchj <[email protected]>
Contributor
sunyuhan1998
left a comment
sunyuhan1998
left a comment
There was a problem hiding this comment.
Please update the Copyright Notice year in the header of all modified files from 2023-2024 to 2023-2025.
Comment on lines
+1
to
+3
| package org.springframework.ai.chat.model; | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Please add a Copyright Notice at the beginning of the file.
Comment on lines
84
to
+86
| String betaPrefixPath, RestClient.Builder restClientBuilder, WebClient.Builder webClientBuilder, | ||
| ResponseErrorHandler responseErrorHandler) { | ||
| ResponseErrorHandler responseErrorHandler, StreamFunctionCallingHelper<ChatCompletionChunk> chunkMerger) { |
Contributor
There was a problem hiding this comment.
Please add this new parameter to the method documentation.
Signed-off-by: sdghchj <[email protected]>
Signed-off-by: sdghchj <[email protected]>
Author
|
@sunyuhan1998 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #3602