Skip to content

Commit 6207e41

Browse files
committed
Remove auto-configuration support for '@HttpServiceClient'
This reverts commit 7a8b337. Closes gh-47123
1 parent fd4f2b8 commit 6207e41

File tree

14 files changed

+82
-594
lines changed

14 files changed

+82
-594
lines changed

module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/autoconfigure/service/ConditionalOnMissingHttpServiceProxyBean.java

Lines changed: 0 additions & 40 deletions
This file was deleted.

module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/autoconfigure/service/OnMissingHttpServiceProxyBeanCondition.java

Lines changed: 0 additions & 73 deletions
This file was deleted.

module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/autoconfigure/service/package-info.java

Lines changed: 0 additions & 23 deletions
This file was deleted.

module/spring-boot-http-client/src/test/java/org/springframework/boot/http/client/autoconfigure/service/ConditionalOnMissingHttpServiceProxyBeanTests.java

Lines changed: 0 additions & 82 deletions
This file was deleted.

module/spring-boot-restclient/src/main/java/org/springframework/boot/restclient/autoconfigure/service/HttpServiceClientAutoConfiguration.java

Lines changed: 41 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,24 @@
1616

1717
package org.springframework.boot.restclient.autoconfigure.service;
1818

19+
import org.springframework.beans.factory.BeanClassLoaderAware;
20+
import org.springframework.beans.factory.ObjectProvider;
1921
import org.springframework.boot.autoconfigure.AutoConfiguration;
22+
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
2023
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2124
import org.springframework.boot.context.properties.EnableConfigurationProperties;
25+
import org.springframework.boot.http.client.ClientHttpRequestFactoryBuilder;
26+
import org.springframework.boot.http.client.ClientHttpRequestFactorySettings;
2227
import org.springframework.boot.http.client.autoconfigure.HttpClientAutoConfiguration;
28+
import org.springframework.boot.restclient.RestClientCustomizer;
2329
import org.springframework.boot.restclient.autoconfigure.RestClientAutoConfiguration;
30+
import org.springframework.boot.ssl.SslBundles;
31+
import org.springframework.context.annotation.Bean;
2432
import org.springframework.context.annotation.Conditional;
25-
import org.springframework.context.annotation.Import;
33+
import org.springframework.web.client.ApiVersionFormatter;
34+
import org.springframework.web.client.ApiVersionInserter;
2635
import org.springframework.web.client.support.RestClientAdapter;
36+
import org.springframework.web.service.registry.HttpServiceProxyRegistry;
2737
import org.springframework.web.service.registry.ImportHttpServices;
2838

2939
/**
@@ -39,9 +49,37 @@
3949
*/
4050
@AutoConfiguration(after = { HttpClientAutoConfiguration.class, RestClientAutoConfiguration.class })
4151
@ConditionalOnClass(RestClientAdapter.class)
52+
@ConditionalOnBean(HttpServiceProxyRegistry.class)
4253
@Conditional(NotReactiveWebApplicationCondition.class)
4354
@EnableConfigurationProperties(HttpClientServiceProperties.class)
44-
@Import({ ImportHttpServiceClientsConfiguration.class, RestClientHttpServiceClientConfiguration.class })
45-
public final class HttpServiceClientAutoConfiguration {
55+
public final class HttpServiceClientAutoConfiguration implements BeanClassLoaderAware {
56+
57+
@SuppressWarnings("NullAway.Init")
58+
private ClassLoader beanClassLoader;
59+
60+
HttpServiceClientAutoConfiguration() {
61+
}
62+
63+
@Override
64+
public void setBeanClassLoader(ClassLoader classLoader) {
65+
this.beanClassLoader = classLoader;
66+
}
67+
68+
@Bean
69+
RestClientPropertiesHttpServiceGroupConfigurer restClientPropertiesHttpServiceGroupConfigurer(
70+
ObjectProvider<SslBundles> sslBundles, HttpClientServiceProperties serviceProperties,
71+
ObjectProvider<ClientHttpRequestFactoryBuilder<?>> clientFactoryBuilder,
72+
ObjectProvider<ClientHttpRequestFactorySettings> clientHttpRequestFactorySettings,
73+
ObjectProvider<ApiVersionInserter> apiVersionInserter,
74+
ObjectProvider<ApiVersionFormatter> apiVersionFormatter) {
75+
return new RestClientPropertiesHttpServiceGroupConfigurer(this.beanClassLoader, sslBundles, serviceProperties,
76+
clientFactoryBuilder, clientHttpRequestFactorySettings, apiVersionInserter, apiVersionFormatter);
77+
}
78+
79+
@Bean
80+
RestClientCustomizerHttpServiceGroupConfigurer restClientCustomizerHttpServiceGroupConfigurer(
81+
ObjectProvider<RestClientCustomizer> customizers) {
82+
return new RestClientCustomizerHttpServiceGroupConfigurer(customizers);
83+
}
4684

4785
}

module/spring-boot-restclient/src/main/java/org/springframework/boot/restclient/autoconfigure/service/ImportHttpServiceClientsConfiguration.java

Lines changed: 0 additions & 62 deletions
This file was deleted.

0 commit comments

Comments
 (0)