Do not detect multiple child repositories of base repository class

[Madina-S]

I have two types of entities: ordinary and ordered and two types of repositories accordingly.

@MappedSuperclass
@EntityListeners(AuditingEntityListener::class)
abstract class BaseEntity(
    @Id @GeneratedValue(strategy = GenerationType.IDENTITY) var id: Long = 0,
    @CreatedDate @Temporal(TemporalType.TIMESTAMP) var createdDate: Date? = null,
    @CreatedBy var createdBy: Long? = null,
    @LastModifiedBy var lastModifiedBy: Long? = null,
    @LastModifiedDate @Temporal(TemporalType.TIMESTAMP) var modifiedDate: Date? = null,
    @Column(nullable = false) @ColumnDefault(value = "false") var deleted: Boolean = false
)

@MappedSuperclass
abstract class OrderedBaseEntity(
    var ordered: Int = 0
) : BaseEntity()

@Entity
class Category(
    var title: String,
    var logo: String,
    order: Int = 0
) : OrderedBaseEntity(order)

@NoRepositoryBean
interface JpaBaseRepository<T : BaseEntity> : JpaRepository<T, Long>, JpaSpecificationExecutor<T> {
    @Modifying
    @Transactional
    @Query("UPDATE #{#entityName} e SET e.deleted = true WHERE e.id IN :ids AND e.deleted = false")
    fun trashAllByIds(ids: List<Long>) = 0

    fun findByIdAndDeletedFalse(id: Long): T?
    fun trash(id: Long): T?
    fun findAllNotDeleted(): List<T>
    fun findAllNotDeletedPage(pageable: Pageable): Page<T>
}

@NoRepositoryBean
interface JpaOrderedBaseRepository<T : OrderedBaseEntity> : JpaBaseRepository<T> {
    fun findOrderedActive(): List<T>
}

class JpaBaseRepositoryImpl<T : BaseEntity>(
    entityInformation: JpaEntityInformation<T, Long>,
    entityManager: EntityManager
) : SimpleJpaRepository<T, Long>(entityInformation, entityManager), JpaBaseRepository<T> {

    val isNotDeletedSpecification = Specification<T> { root, _, cb -> cb.equal(root.get<Boolean>("deleted"), false) }

    override fun findByIdAndDeletedFalse(id: Long) = findByIdOrNull(id)?.run { if (deleted) null else this }

    @Transactional
    override fun trash(id: Long): T? = findByIdOrNull(id)?.run {
        deleted = true
        save(this)
    }

    override fun findAllNotDeleted(): List<T> = findAll(isNotDeletedSpecification)
    override fun findAllNotDeletedPage(pageable: Pageable): Page<T> = findAll(isNotDeletedSpecification, pageable)
}

class JpaBaseOrderedRepositoryImpl<T : OrderedBaseEntity>(
    entityInformation: JpaEntityInformation<T, Long>,
    entityManager: EntityManager
) : JpaBaseRepositoryImpl<T>(entityInformation, entityManager), JpaOrderedBaseRepository<T> {

    override fun findOrderedActive(): List<T> =
        findAll(isNotDeletedSpecification, Sort.by(Sort.Direction.ASC, "ordered"))
}

@Repository
interface CategoryRepository : JpaOrderedBaseRepository<Category>

@EnableJpaRepositories(repositoryBaseClass = JpaBaseRepositoryImpl::class)
@SpringBootApplication
class CoreApplication

Error is : Failed to create query for method public abstract java.util.List pro.talim.beta.core.common.JpaOrderedBaseRepository.findOrderedActive(); No property 'findOrderedActive' found for type 'Category'

[mp911de]

In your configuration you've provided only JpaBaseRepositoryImpl as base repository that doesn't implement the findOrderedActive method. Base repository implementations are instantiated per repository instance as their entity information is bound to a single domain type. In contrast, fragments are singletons that are shared across multiple repositories. I suggest that you move the findOrderedActive method into JpaBaseRepositoryImpl. Your repositories can extend still from JpaBaseRepository without the need to expose the additional findOrderedActive method. Selected repositories (like CategoryRepository) can still make use of JpaOrderedBaseRepository as the method will be mounted and calls will be routed accordingly.

TL;DR: You don't need to expose all methods in the actual repository but you can equip your base repository with more functionality to selectively decide which methods should be a available on a repository.

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[Madina-S]

What kind of information should I provide?

[schauder]

If the advice @mp911de gave you solved your problem. If not, we would need additional information, ideally a full reproducer.

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.