Skip to content

Commit 49c4a45

Browse files
onobcdsyer
authored andcommitted
Update docs to clarify required versions.
This updates the docs in several places in order to clarify which versions of Java, Spring, and Spring Boot are supported. Signed-off-by: onobc <[email protected]>
1 parent 32e49d4 commit 49c4a45

File tree

7 files changed

+38
-5
lines changed

7 files changed

+38
-5
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Contribution Guidelines
22

3+
## Building from Source
4+
5+
Java 25 is the preferred version to build with as we leverage [JSpecify](https://jspecify.dev/docs/start-here/) to validate nullability constraints in the source code.
6+
7+
However, if you can not use Java 25 for some reason, you can still build locally with Java 17.
8+
In this scenario the nullability constraints will not be validated locally but rather via the continuous integration pull request workflow.
9+
310
## Code Formatting and Javadoc
411

512
Before submitting a PR, please run the following commands to ensure proper formatting and Javadoc processing

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ For further information go to our [Spring gRPC reference documentation](https://
99

1010
# Getting Started
1111

12+
**📌 NOTE**\
13+
Spring gRPC `1.0.x` supports Spring Boot `4.0.x.`
14+
1215
This section offers jumping off points for how to get started using Spring gRPC. There is a simple sample project in the `samples` directory (e.g. [`grpc-server`](https://github.com/spring-projects/spring-grpc/tree/main/samples/grpc-server)). You can run it with `mvn spring-boot:run` or `gradle bootRun`. You will see the following code in that sample.
1316

1417
Want to get started? Let’s speedrun a working service.
@@ -146,9 +149,6 @@ More details on what is going on in the next section.
146149

147150
You should follow the steps in each of the following section according to your needs.
148151

149-
**📌 NOTE**\
150-
Spring gRPC supports Spring Boot 3.4.x and 3.5.x
151-
152152
### Add Milestone and Snapshot Repositories
153153

154154
If you prefer to add the dependency snippets by hand, follow the directions in the following sections.

spring-grpc-docs/src/main/antora/modules/ROOT/nav.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
* xref:index.adoc[Overview]
22
* xref:whats-new.adoc[What's new?]
3+
* xref:system-requirements.adoc[System Requirements]
34
* xref:getting-started.adoc[Getting Started]
45
* xref:server.adoc[GRPC Server]
56
* xref:client.adoc[GRPC Clients]
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
:spring-grpc-version: 1.0.x
2+
:spring-framework-version: 7.0.1
3+
:spring-boot-version: 4.0.x
4+
:spring-framework-docs: https://spring.io/projects/spring-framework#learn
5+
:spring-boot-docs: https://spring.io/projects/spring-boot#learn

spring-grpc-docs/src/main/antora/modules/ROOT/pages/contribution-guidelines.adoc

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
[[contribution-guidelines]]
22
= Contribution Guidelines
33

4+
== Building from Source
5+
6+
Java 25 is the preferred version to build with as we leverage https://jspecify.dev/docs/start-here/[JSpecify] to validate nullability constraints in the source code.
7+
8+
However, if you can not use Java 25 for some reason, you can still build locally with Java 17.
9+
In this scenario the nullability constraints will not be validated locally but rather via the continuous integration pull request workflow.
10+
411
== Code Formatting and Javadoc
512

613
Before submitting a PR, please run the following commands to ensure proper formatting and Javadoc processing

spring-grpc-docs/src/main/antora/modules/ROOT/pages/getting-started.adoc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
[[getting-started]]
22
= Getting Started
33

4+
include::./attributes/attributes-variables.adoc[]
5+
6+
NOTE: Spring gRPC `{spring-grpc-version}` supports Spring Boot `{spring-boot-version}`
7+
48
This section offers jumping off points for how to get started using Spring gRPC. There is a simple sample project in the `samples` directory (e.g. https://github.com/spring-projects/spring-grpc/tree/main/samples/grpc-server[`grpc-server`]). You can run it with `mvn spring-boot:run` or `gradle bootRun`. You will see the following code in that sample.
59

610
Want to get started? Let's speedrun a working service.
@@ -146,8 +150,6 @@ More details on what is going on in the next section.
146150

147151
You should follow the steps in each of the following section according to your needs.
148152

149-
NOTE: Spring gRPC supports Spring Boot 3.4.x and 3.5.x
150-
151153
[[repositories]]
152154
=== Add Milestone and Snapshot Repositories
153155

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
[[system-requirements]]
2+
= System Requirements
3+
4+
include::./attributes/attributes-variables.adoc[]
5+
6+
Spring gRPC `{spring-grpc-version}` requires the following:
7+
8+
- https://www.java.com[Java 17] and is compatible up to and including Java 25
9+
- {spring-framework-docs}[Spring Framework `{spring-framework-version}`] or above
10+
11+
We recommend a Spring Boot first approach and Spring gRPC `{spring-grpc-version}` supports {spring-boot-docs}[Spring Boot] `{spring-boot-version}.`

0 commit comments

Comments
 (0)