fix scroller on threads, handling of null mentions or with no value

mmckegg · mmckegg · commit d67e24a75179 · 2018-10-11T00:10:05.000+13:00
diff --git a/lib/scroller.js b/lib/scroller.js
@@ -44,7 +44,7 @@ function Scroller (scroller, content, render, opts) {
     entries.forEach(entry => {
       if (entry.isIntersecting) {
         visibleObserver.unobserve(entry.target)
-        onceIdle(() => opts.onItemVisible(entry.target))
+        onceIdle(() => opts.onItemVisible && opts.onItemVisible(entry.target))
       }
     })
   }, {
diff --git a/sbot/mentions-feed.js b/sbot/mentions-feed.js
@@ -120,7 +120,7 @@ exports.init = function (ssb, config) {
 }
 
 function checkBump (msg, { id }) {
-  if (msg.value.author !== id) {
+  if (msg && msg.value && msg.value.author !== id) {
     if (Array.isArray(msg.value.content.mentions) && msg.value.content.mentions.some(mention => {
       return mention && mention.link === id
     })) {

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ function Scroller (scroller, content, render, opts) {`
`44`	`44`	`entries.forEach(entry => {`
`45`	`45`	`if (entry.isIntersecting) {`
`46`	`46`	`visibleObserver.unobserve(entry.target)`
`47`		`- onceIdle(() => opts.onItemVisible(entry.target))`
	`47`	`+ onceIdle(() => opts.onItemVisible && opts.onItemVisible(entry.target))`
`48`	`48`	`}`
`49`	`49`	`})`
`50`	`50`	`}, {`
Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ exports.init = function (ssb, config) {`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`function checkBump (msg, { id }) {`
`123`		`- if (msg.value.author !== id) {`
	`123`	`+ if (msg && msg.value && msg.value.author !== id) {`
`124`	`124`	`if (Array.isArray(msg.value.content.mentions) && msg.value.content.mentions.some(mention => {`
`125`	`125`	`return mention && mention.link === id`
`126`	`126`	`})) {`