Skip to content

Commit af65ff8

Browse files
committed
Remove getElementsByTagNameNS() for cases which can never find a element
1 parent d8bf935 commit af65ff8

File tree

2 files changed

+12
-26
lines changed

2 files changed

+12
-26
lines changed

src/Report/Xml/Project.php

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -63,19 +63,12 @@ public function buildInformation(): BuildInformation
6363

6464
public function tests(): Tests
6565
{
66-
$testsNode = $this->contextNode()->getElementsByTagNameNS(
67-
Facade::XML_NAMESPACE,
68-
'tests',
69-
)->item(0);
70-
71-
if ($testsNode === null) {
72-
$testsNode = $this->contextNode()->appendChild(
73-
$this->dom()->createElementNS(
74-
Facade::XML_NAMESPACE,
75-
'tests',
76-
),
77-
);
78-
}
66+
$testsNode = $this->contextNode()->appendChild(
67+
$this->dom()->createElementNS(
68+
Facade::XML_NAMESPACE,
69+
'tests',
70+
),
71+
);
7972

8073
assert($testsNode instanceof DOMElement);
8174

src/Report/Xml/Report.php

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -119,19 +119,12 @@ public function traitObject(
119119

120120
public function source(): Source
121121
{
122-
$source = $this->contextNode()->getElementsByTagNameNS(
123-
Facade::XML_NAMESPACE,
124-
'source',
125-
)->item(0);
126-
127-
if ($source === null) {
128-
$source = $this->contextNode()->appendChild(
129-
$this->dom()->createElementNS(
130-
Facade::XML_NAMESPACE,
131-
'source',
132-
),
133-
);
134-
}
122+
$source = $this->contextNode()->appendChild(
123+
$this->dom()->createElementNS(
124+
Facade::XML_NAMESPACE,
125+
'source',
126+
),
127+
);
135128

136129
assert($source instanceof DOMElement);
137130

0 commit comments

Comments
 (0)