Drop DOM dependency

Author: staabm

src/Report/Xml/BuildInformation.php

@@ -9,6 +9,7 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
+use XMLWriter;
 use function assert;
 use function phpversion;
 use DateTimeImmutable;
@@ -20,52 +21,37 @@
  */
 final readonly class BuildInformation
 {
-    private DOMElement $contextNode;
-
     public function __construct(
-        DOMElement $contextNode,
+        XMLWriter $xmlWriter,
         Runtime $runtime,
         DateTimeImmutable $buildDate,
         string $phpUnitVersion,
         string $coverageVersion
     ) {
-        $this->contextNode = $contextNode;
-
-        $runtimeNode = $this->nodeByName('runtime');
-
-        $runtimeNode->setAttribute('name', $runtime->getName());
-        $runtimeNode->setAttribute('version', $runtime->getVersion());
-        $runtimeNode->setAttribute('url', $runtime->getVendorUrl());
-
-        $driverNode = $this->nodeByName('driver');
-
+        $xmlWriter->startElement('build');
+        $xmlWriter->writeAttribute('time', $buildDate->format('D M j G:i:s T Y'));
+        $xmlWriter->writeAttribute('phpunit', $phpUnitVersion);
+        $xmlWriter->writeAttribute('coverage', $coverageVersion);
+
+        $xmlWriter->startElement('runtime');
+        $xmlWriter->writeAttribute('name', $runtime->getName());
+        $xmlWriter->writeAttribute('version', $runtime->getVersion());
+        $xmlWriter->writeAttribute('url', $runtime->getVendorUrl());
+        $xmlWriter->endElement();
+
+        $xmlWriter->startElement('driver');
         if ($runtime->hasXdebug()) {
-            $driverNode->setAttribute('name', 'xdebug');
-            $driverNode->setAttribute('version', phpversion('xdebug'));
+            $xmlWriter->writeAttribute('name', 'xdebug');
+            $xmlWriter->writeAttribute('version', phpversion('xdebug'));
         }
 
         if ($runtime->hasPCOV()) {
-            $driverNode->setAttribute('name', 'pcov');
-            $driverNode->setAttribute('version', phpversion('pcov'));
+            $xmlWriter->writeAttribute('name', 'pcov');
+            $xmlWriter->writeAttribute('version', phpversion('pcov'));
         }
+        $xmlWriter->endElement();
 
-        $this->contextNode->setAttribute('time', $buildDate->format('D M j G:i:s T Y'));
-
-        $this->contextNode->setAttribute('phpunit', $phpUnitVersion);
-        $this->contextNode->setAttribute('coverage', $coverageVersion);
+        $xmlWriter->endElement();
     }
 
-    private function nodeByName(string $name): DOMElement
-    {
-        $node = $this->contextNode->appendChild(
-            $this->contextNode->ownerDocument->createElementNS(
-                Facade::XML_NAMESPACE,
-                $name,
-            ),
-        );
-
-        assert($node instanceof DOMElement);
-
-        return $node;
-    }
 }

src/Report/Xml/Facade.php

@@ -9,6 +9,7 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
+use XMLWriter;
 use const DIRECTORY_SEPARATOR;
 use function count;
 use function dirname;
@@ -47,9 +48,12 @@ final class Facade
     private Project $project;
     private readonly string $phpUnitVersion;
 
+    protected readonly XMLWriter $xmlWriter;
+
     public function __construct(string $version)
     {
         $this->phpUnitVersion = $version;
+        $this->xmlWriter = new XMLWriter();
     }
 
     /**
@@ -67,6 +71,7 @@ public function process(CodeCoverage $coverage, string $target): void
         $report = $coverage->getReport();
 
         $this->project = new Project(
+            $this->xmlWriter,
             $coverage->getReport()->name(),
         );
 
@@ -232,11 +237,15 @@ private function processFunction(ProcessedFunctionType $function, Report $report
      */
     private function processTests(array $tests): void
     {
+        $this->xmlWriter->startElement('tests');
+
         $testsObject = $this->project->tests();
 
         foreach ($tests as $test => $result) {
             $testsObject->addTest($test, $result);
         }
+
+        $this->xmlWriter->endElement();
     }
 
     private function setTotals(AbstractNode $node, Totals $totals): void

src/Report/Xml/Node.php

@@ -9,6 +9,7 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
+use XMLWriter;
 use function assert;
 use DOMDocument;
 use DOMElement;
@@ -18,13 +19,12 @@
  */
 abstract class Node
 {
-    protected readonly DOMDocument $dom;
-    private readonly DOMElement $contextNode;
+    protected readonly XMLWriter $xmlWriter;
 
-    public function __construct(DOMElement $context)
+
+    public function __construct(XMLWriter $xmlWriter)
     {
-        $this->dom         = $context->ownerDocument;
-        $this->contextNode = $context;
+        $this->xmlWriter = $xmlWriter;
     }
 
     public function totals(): Totals

src/Report/Xml/Project.php

@@ -9,10 +9,9 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
-use function assert;
+use XMLWriter;
 use DateTimeImmutable;
 use DOMDocument;
-use DOMElement;
 use SebastianBergmann\Environment\Runtime;
 
 /**
@@ -22,17 +21,16 @@ final class Project extends Node
 {
     private readonly string $directory;
 
-    public function __construct(string $directory)
+    public function __construct(XMLWriter $xmlWriter, string $directory)
     {
-        $dom = new DOMDocument;
-        $dom->loadXML('<?xml version="1.0" ?><phpunit xmlns="https://schema.phpunit.de/coverage/1.0"><build/><project/></phpunit>');
+        parent::__construct($xmlWriter);
 
-        parent::__construct(
-            $dom->getElementsByTagNameNS(
-                Facade::XML_NAMESPACE,
-                'project',
-            )->item(0),
-        );
+        $this->xmlWriter->openMemory();
+        $this->xmlWriter->startDocument('1.0', 'UTF-8');
+
+        $this->xmlWriter->startElementNs(null, 'phpunit', Facade::XML_NAMESPACE);
+        $this->xmlWriter->startElement('project');
+        $this->xmlWriter->writeAttribute('source', $this->directory);
 
         $this->directory = $directory;
     }
@@ -48,15 +46,8 @@ public function buildInformation(
         string $phpUnitVersion,
         string $coverageVersion
     ): void {
-        $buildNode = $this->dom->getElementsByTagNameNS(
-            Facade::XML_NAMESPACE,
-            'build',
-        )->item(0);
-
-        assert($buildNode instanceof DOMElement);
-
         new BuildInformation(
-            $buildNode,
+            $this->xmlWriter,
             $runtime,
             $buildDate,
             $phpUnitVersion,
@@ -66,21 +57,12 @@ public function buildInformation(
 
     public function tests(): Tests
     {
-        $testsNode = $this->contextNode()->appendChild(
-            $this->dom->createElementNS(
-                Facade::XML_NAMESPACE,
-                'tests',
-            ),
-        );
-
-        assert($testsNode instanceof DOMElement);
-
-        return new Tests($testsNode);
+        return new Tests($this->xmlWriter);
     }
 
     public function asDom(): DOMDocument
     {
-        $this->contextNode()->setAttribute('source', $this->directory);
+        $this->xmlWriter->endElement();
 
         return $this->dom;
     }

src/Report/Xml/Tests.php

@@ -9,6 +9,7 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
+use XMLWriter;
 use function assert;
 use DOMElement;
 use SebastianBergmann\CodeCoverage\CodeCoverage;
@@ -20,29 +21,23 @@
  */
 final readonly class Tests
 {
-    private DOMElement $contextNode;
-
-    public function __construct(DOMElement $context)
+    private readonly XMLWriter $xmlWriter;
+    public function __construct(XMLWriter $xmlWriter)
     {
-        $this->contextNode = $context;
+        $this->xmlWriter = $xmlWriter;
     }
 
     /**
      * @param TestType $result
      */
     public function addTest(string $test, array $result): void
     {
-        $node = $this->contextNode->appendChild(
-            $this->contextNode->ownerDocument->createElementNS(
-                Facade::XML_NAMESPACE,
-                'test',
-            ),
-        );
+        $this->xmlWriter->startElement('test');
 
-        assert($node instanceof DOMElement);
+        $this->xmlWriter->writeAttribute('name', $test);
+        $this->xmlWriter->writeAttribute('size', $result['size']);
+        $this->xmlWriter->writeAttribute('status', $result['status']);
 
-        $node->setAttribute('name', $test);
-        $node->setAttribute('size', $result['size']);
-        $node->setAttribute('status', $result['status']);
+        $this->xmlWriter->endAttribute();
     }
 }